From 2bc462f645824a439879190ed19a231cb5b8034c Mon Sep 17 00:00:00 2001 From: Nicola Vetrini Date: Wed, 29 May 2024 09:57:28 +0200 Subject: [PATCH] x86: address violations of MISRA C Rule 8.4 Rule 8.4 states: "A compatible declaration shall be visible when an object or function with external linkage is defined." These variables are only referenced from assembly code, so they need to be extern and there is negligible risk of them being used improperly without noticing. As a result, they can be exempted using a comment-based deviation. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- xen/arch/x86/desc.c | 1 + xen/arch/x86/mm.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/desc.c b/xen/arch/x86/desc.c index 39080ca672..9f63928154 100644 --- a/xen/arch/x86/desc.c +++ b/xen/arch/x86/desc.c @@ -91,6 +91,7 @@ seg_desc_t boot_compat_gdt[PAGE_SIZE / sizeof(seg_desc_t)] = * References boot_cpu_gdt_table for a short period, until the CPUs switch * onto their per-CPU GDTs. */ +/* SAF-1-safe */ const struct desc_ptr boot_gdtr = { .limit = LAST_RESERVED_GDT_BYTE, .base = (unsigned long)(boot_gdt - FIRST_RESERVED_GDT_ENTRY), diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index d968bbbc73..17987eb519 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -144,7 +144,7 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap[L1_PAGETABLE_ENTRIES]; l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) - l1_fixmap_x[L1_PAGETABLE_ENTRIES]; + l1_fixmap_x[L1_PAGETABLE_ENTRIES]; /* SAF-1-safe */ bool __read_mostly machine_to_phys_mapping_valid; -- 2.39.5