From 2389f0a3b2c36737e99e942cff3da2cf33050831 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Mon, 7 Apr 2025 13:09:38 +0200 Subject: [PATCH] tools/libxl: do not use `-c -E` compiler options together MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It makes no sense to request for preprocessor only output and also request object file generation. Fix the _libxl.api-for-check target to only use -E (preprocessor output). Also Clang 20.0 reports an error if both options are used. Reported-by: Andrew Cooper Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers') Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper Acked-by: Anthony PERARD (cherry picked from commit a235f856e4bbd270b085590e1f5fc9599234dcdf) --- tools/libs/light/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 37e4d16709..b690d92159 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -195,7 +195,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check touch $@ _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h - $(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \ + $(CC) $(CPPFLAGS) $(CFLAGS) -E $< $(APPEND_CFLAGS) \ -DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \ >$@.new mv -f $@.new $@ -- 2.39.5