From 222f6233b4f441b8e70194f21c574d03f16df3f8 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Mon, 4 Jul 2011 10:32:22 +0800 Subject: [PATCH] vmware: avoid null deref on failed lookup * src/vmware/vmware_driver.c (vmwareDomainReboot): Check error before dereferencing memory. --- src/vmware/vmware_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index 5e2c4ba6b..52582d628 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -461,7 +461,6 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED) vmwareDriverLock(driver); vm = virDomainFindByUUID(&driver->domains, dom->uuid); vmwareDriverUnlock(driver); - vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath; if (!vm) { vmwareError(VIR_ERR_NO_DOMAIN, "%s", @@ -469,6 +468,7 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED) goto cleanup; } + vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath; vmwareSetSentinal(cmd, vmw_types[driver->type]); vmwareSetSentinal(cmd, vmxPath); -- 2.39.5