From 21a9be4412d8f8aca22e55ac2d05146143b468c5 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 2 Dec 2021 10:48:54 +0100 Subject: [PATCH] VIR_REQUIRE_FLAG_(GOTO|RET): Add parens around arguments in expansion MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Make the macro useful also for cases when one of multiple flags is required. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/internal.h b/src/internal.h index 2e404cd705..b6e4332542 100644 --- a/src/internal.h +++ b/src/internal.h @@ -374,7 +374,7 @@ */ #define VIR_REQUIRE_FLAG_RET(FLAG1, FLAG2, RET) \ do { \ - if ((flags & FLAG1) && !(flags & FLAG2)) { \ + if ((flags & (FLAG1)) && !(flags & (FLAG2))) { \ virReportInvalidArg(ctl, \ _("Flag '%s' is required by flag '%s'"), \ #FLAG2, #FLAG1); \ @@ -396,7 +396,7 @@ */ #define VIR_REQUIRE_FLAG_GOTO(FLAG1, FLAG2, LABEL) \ do { \ - if ((flags & FLAG1) && !(flags & FLAG2)) { \ + if ((flags & (FLAG1)) && !(flags & (FLAG2))) { \ virReportInvalidArg(ctl, \ _("Flag '%s' is required by flag '%s'"), \ #FLAG2, #FLAG1); \ -- 2.39.5