From 1ea7f6353405a59fea8d11f2ec1ca08ba3b299d0 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 13 Apr 2021 10:15:08 +0200 Subject: [PATCH] VT-d: don't open-code dmar_readl() While at it also drop the unnecessary use of a local variable there. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- xen/drivers/passthrough/vtd/iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 10c71132db..b2ca152e1f 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -990,8 +990,7 @@ static void __do_iommu_page_fault(struct vtd_iommu *iommu) } clear_overflow: /* clear primary fault overflow */ - fault_status = readl(iommu->reg + DMAR_FSTS_REG); - if ( fault_status & DMA_FSTS_PFO ) + if ( dmar_readl(iommu->reg, DMAR_FSTS_REG) & DMA_FSTS_PFO ) { spin_lock_irqsave(&iommu->register_lock, flags); dmar_writel(iommu->reg, DMAR_FSTS_REG, DMA_FSTS_PFO); -- 2.39.5