From 1ccaf39402a502d5bed77d94067d86a679b65a6b Mon Sep 17 00:00:00 2001 From: Nikolay Shirokovskiy Date: Wed, 18 Apr 2018 17:17:37 +0300 Subject: [PATCH] check scripts: handle unintialized driver vars in check-driverimpls.pl MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Current script confuses on lines like this: static virHypervisorDriver parallelsHypervisorDriver; It interprets next lines as if there is open brace. Let's filter this case from matches. Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Daniel P. Berrangé --- src/check-driverimpls.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/check-driverimpls.pl b/src/check-driverimpls.pl index 4c28f2092a..832a3900f4 100755 --- a/src/check-driverimpls.pl +++ b/src/check-driverimpls.pl @@ -67,7 +67,7 @@ while (<>) { $status = 1; } } - } elsif (/^(?:static\s+)?(vir(?:\w+)?Driver)\s+/) { + } elsif (/^(?:static\s+)?(vir(?:\w+)?Driver)\s+(?!.*;)/) { next if $1 eq "virNWFilterCallbackDriver" || $1 eq "virNWFilterTechDriver" || $1 eq "virConnectDriver"; -- 2.39.5