From 19c3016a8a6a889203cf43b86e8218f3ce4821a7 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 8 Nov 2024 17:54:22 +0000 Subject: [PATCH] VT-d: Drop includes of mach_apic.h Neither iommu.c nor quirks.c use any functionality. iommu.c only uses it to transitively include apic.h and io_apic.h, while quirks.c is only depending on the ACLINUX wrapping of strtoul() which we spell simple_strtoul() everywhere else in Xen. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- xen/drivers/passthrough/vtd/iommu.c | 5 ++++- xen/drivers/passthrough/vtd/quirks.c | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index e13be244c1..27a4d16401 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -31,12 +31,15 @@ #include #include #include + +#include +#include #include #include #include #include #include -#include + #include "iommu.h" #include "dmar.h" #include "extern.h" diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index 950dcd56ef..dc3dac749c 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -32,7 +32,7 @@ #include #include #include -#include + #include "iommu.h" #include "dmar.h" #include "extern.h" @@ -321,7 +321,7 @@ static int __init cf_check parse_snb_timeout(const char *s) else if ( strcmp(s, "cap") == 0 ) t = SNB_IGD_TIMEOUT; else - t = strtoul(s, &q, 0); + t = simple_strtoul(s, &q, 0); } else t = t ? SNB_IGD_TIMEOUT_LEGACY : 0; -- 2.39.5