From 18063d6377fc40599e06ef9df5b5f0ea369ba83f Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 21 Sep 2020 12:10:26 +0200 Subject: [PATCH] mm: adjust get_page()'s types MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The passed in domain doesn't get altered and hence can be const. While modifying its prototype anyway, also switch to bool. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Julien Grall --- xen/arch/arm/mm.c | 8 ++++---- xen/arch/x86/mm.c | 8 ++++---- xen/include/xen/mm.h | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 9e2ff7c800..b4763d9a3d 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1560,17 +1560,17 @@ void put_page(struct page_info *page) } } -int get_page(struct page_info *page, struct domain *domain) +bool get_page(struct page_info *page, const struct domain *domain) { - struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_reference(page); if ( likely(owner == domain) ) - return 1; + return true; if ( owner != NULL ) put_page(page); - return 0; + return false; } /* Common code requires get_page_type and put_page_type. diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 42a6dc9ba4..2c13a2d8e7 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2510,12 +2510,12 @@ struct domain *page_get_owner_and_reference(struct page_info *page) } -int get_page(struct page_info *page, struct domain *domain) +bool get_page(struct page_info *page, const struct domain *domain) { - struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_reference(page); if ( likely(owner == domain) ) - return 1; + return true; if ( !paging_mode_refcounts(domain) && !domain->is_dying ) gprintk(XENLOG_INFO, @@ -2526,7 +2526,7 @@ int get_page(struct page_info *page, struct domain *domain) if ( owner ) put_page(page); - return 0; + return false; } /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 1061765bcd..4536a62940 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -151,7 +151,7 @@ TYPE_SAFE(unsigned long, pfn); struct page_info; void put_page(struct page_info *); -int get_page(struct page_info *, struct domain *); +bool get_page(struct page_info *, const struct domain *); struct domain *__must_check page_get_owner_and_reference(struct page_info *); /* Boot-time allocator. Turns into generic allocator after bootstrap. */ -- 2.39.5