From 1626164929d54dc57a1f43e24f5560f13f2420fe Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Mon, 23 Jul 2018 11:26:48 +0100 Subject: [PATCH] tools/gdbsx: fix build with clang 3.8 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Currently building gdbsx with clang 3.8 gives the following errors: xg_main.c:783:17: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes] iop->uva = (uint64_aligned_t)((unsigned long)tobuf); ^~~~~~~~~~~~~~~~ /builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50: note: expanded from macro 'uint64_aligned_t' ^~~~~~~~~~ xg_main.c:816:17: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes] iop->uva = (uint64_aligned_t)((unsigned long)frombuf); ^~~~~~~~~~~~~~~~ /builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50: note: expanded from macro 'uint64_aligned_t' According to https://bugs.llvm.org/show_bug.cgi?id=11071, this issue has been fixed in clang. But we're not going to get that in 3.8. Explicitly disable that warning to fix the build. Signed-off-by: Wei Liu Reviewed-by: Roger Pau Monné Acked-by: Andrew Cooper --- tools/debugger/gdbsx/Rules.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk index 6e38f2df99..920f1c87fb 100644 --- a/tools/debugger/gdbsx/Rules.mk +++ b/tools/debugger/gdbsx/Rules.mk @@ -2,3 +2,5 @@ include $(XEN_ROOT)/tools/Rules.mk CFLAGS += -Werror -Wmissing-prototypes # (gcc 4.3x and later) -Wconversion -Wno-sign-conversion + +CFLAGS-$(clang) += -Wno-ignored-attributes -- 2.39.5