From 0fa2525b81c0f9065e4a90e458a5b0c014daa05a Mon Sep 17 00:00:00 2001 From: Anthony PERARD Date: Thu, 13 Jun 2019 12:20:31 +0100 Subject: [PATCH] libxl_usb: Fix wrong usage of asserts Replace the assert(0) by abort() since the intention in libxl is that asserts are always compiled in. This patch makes its clear and removes the need to deal with asserts been compiled out. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index 3d389c0198..9f72857d87 100644 --- a/tools/libxl/libxl_usb.c +++ b/tools/libxl/libxl_usb.c @@ -147,8 +147,7 @@ static int libxl__device_from_usbctrl(libxl__gc *gc, uint32_t domid, device->backend_kind = LIBXL__DEVICE_KIND_NONE; break; default: - assert(0); /* can't really happen. */ - break; + abort(); /* can't really happen. */ } device->devid = usbctrl->devid; device->domid = domid; @@ -370,8 +369,7 @@ static int libxl__device_usbctrl_add_hvm(libxl__gc *gc, uint32_t domid, flexarray_append_pair(qmp_args, "p3", GCSPRINTF("%d", usbctrl->ports)); break; default: - assert(0); /* Should not be possible. */ - break; + abort(); /* Should not be possible. */ } flexarray_append_pair(qmp_args, "id", -- 2.39.5