From 062d14efe2f006138d53418b37b02361383e2603 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Wed, 17 Feb 2016 14:04:14 +0000 Subject: [PATCH] xl: use xrealloc in domain create Using bare realloc risks leaking the old pointer if the realloc fails. Since xrealloc exits on such failures, drop the error handling. Noticed while fixing, but not related to, CID 1055898. Signed-off-by: Ian Campbell Acked-by: Ian Jackson --- tools/libxl/xl_cmdimpl.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index d07ccb2a5e..2271e757c1 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -2793,12 +2793,8 @@ static uint32_t create_domain(struct domain_create *dom_info) return ERROR_FAIL; } /* allocate space for the extra config plus two EOLs plus \0 */ - config_data = realloc(config_data, config_len + config_data = xrealloc(config_data, config_len + strlen(extra_config) + 2 + 1); - if (!config_data) { - fprintf(stderr, "Failed to realloc config_data\n"); - return ERROR_FAIL; - } config_len += sprintf(config_data + config_len, "\n%s\n", extra_config); } -- 2.39.5