]> xenbits.xensource.com Git - libvirt.git/commit
conf: Validate device on update-device
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 5 Sep 2017 14:24:14 +0000 (16:24 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 6 Sep 2017 09:19:30 +0000 (11:19 +0200)
commitc57f3fd2f8999d17e01272246b26d31179ab7b6e
treec4b69abc3d784876906de13eb98c9ef4a4475e3b
parentfbe315bdc89732225d2d5b898468569fd2a1fa25
conf: Validate device on update-device

https://bugzilla.redhat.com/show_bug.cgi?id=1439991

Whenever a device is being updated via
virDomainUpdateDeviceFlags() API, we parse the device XML and
ideally run some generic checks to validate the configuration
(e.g. if device defines per-device boot order but the domain has
os/boot element already). Well, that's the theory - due to a
missing check we've jumped early from that check function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/conf/domain_conf.c
src/conf/domain_conf.h
src/lxc/lxc_driver.c
src/qemu/qemu_driver.c