]> xenbits.xensource.com Git - libvirt.git/commit
qemu: domain: Drop added features from migratable CPU
authorJiri Denemark <jdenemar@redhat.com>
Mon, 11 Mar 2024 16:04:48 +0000 (17:04 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 14 Mar 2024 15:15:06 +0000 (16:15 +0100)
commit14d3517410021d59cb53fb4c841a5d9922e814d1
tree0b9b2366f77a9a3a14f64a8bfd956041fde51cee
parent577c4ca414b26c8586f2586978e55c948bec0a32
qemu: domain: Drop added features from migratable CPU

Features marked with added='yes' in CPU model definitions have to be
removed before migration, otherwise older libvirt would complain about
unknown CPU features. We only do this for features that were enabled for
a given CPU model even with older libvirt, which just ignored the
features. And only for features we added ourselves when updating CPU
definition during domain startup, that is we do not remove features
which were explicitly mentioned by a user.

That said, this is not the safest thing we could do, but it's
effectively the same thing we did before the affected features were
added: we ignored them completely on both sides of migration.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
src/qemu/qemu_migration_cookie.c