]> xenbits.xensource.com Git - xen.git/commit
tools/ocaml/libs: Don't declare stubs as taking void
authorEdwin Török <edwin.torok@cloud.com>
Thu, 12 Jan 2023 11:28:29 +0000 (11:28 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 6 Feb 2023 10:22:12 +0000 (10:22 +0000)
commitff8b560be80b9211c303d74df7e4b3921d2bb8ca
tree0187c6de83bba05613370ff1ec4da5b8cd5d7386
parente6f07052ce4a0f0b7d4dc522d87465efb2d9ee86
tools/ocaml/libs: Don't declare stubs as taking void

There is no such thing as an Ocaml function (C stub or otherwise) taking no
parameters.  In the absence of any other parameters, unit is still passed.

This doesn't explode with any ABI we care about, but would malfunction for an
ABI environment such as stdcall.

Fixes: c3afd398ba7f ("ocaml: Add XS bindings.")
Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.")
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
tools/ocaml/libs/xb/xenbus_stubs.c
tools/ocaml/libs/xc/xenctrl_stubs.c