]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Remove unused persistentAddrs
authorJohn Ferlan <jferlan@redhat.com>
Tue, 24 May 2016 22:40:22 +0000 (18:40 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 25 May 2016 10:02:42 +0000 (06:02 -0400)
commitfb06350021d755c8a443cbb7b13a4c9a64f9fd5f
tree0a3d4c3b5d93650dfbe3df9c1c8daecfed0ce3d5
parentf30672d5ee509fac136905c141d28e5f4325ae5b
qemu: Remove unused persistentAddrs

Based on some digital archaeology performed by jtomko, it's been determined
that the persistentAddrs variable is no longer necessary...

The variable was added by:
commit 141dea6bc7222107c2357acb68066baea5b26df3
CommitDate: 2010-02-12 17:25:52 +0000
    Add persistence of PCI addresses to QEMU

Where it was set to 0 on domain startup if qemu did not support the
QEMUD_CMD_FLAG_DEVICE capability, to clear the addresses at shutdown,
because QEMU might make up different ones next time.

As of commit f5dd58a6088cfc6e8bd354b693d399807a8ec395
CommitDate: 2012-07-11 11:19:05 +0200
    qemu: Extended qemuDomainAssignAddresses to be callable from
    everywhere.

this was broken, when the persistentAddrs = 0 assignment was moved
inside qemuDomainAssignPCIAddresses and while it pretends to check
for !QEMU_CAPS_DEVICE, its parent qemuDomainAssignAddresses is only
called if QEMU_CAPS_DEVICE is present.
src/qemu/qemu_domain.h
src/qemu/qemu_domain_address.c
src/qemu/qemu_process.c