]> xenbits.xensource.com Git - xen.git/commit
x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled
authorJan Beulich <jbeulich@suse.com>
Fri, 2 Dec 2022 09:35:01 +0000 (10:35 +0100)
committerJan Beulich <jbeulich@suse.com>
Fri, 2 Dec 2022 09:35:01 +0000 (10:35 +0100)
commitf1d7aac1e3c3cd164e17d41791a575a5c3e87121
tree7e76631c744f3e392ae2d72214e76a02c13641d4
parentb39e6385250ccef9509af0eab9003ad5c1478842
x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled

In software-disabled state an LAPIC does not accept any interrupt
requests and hence no IRR bit would newly become set while in this
state. As a result it is also wrong for us to mark IO-APIC or MSI
originating vectors as having a pending request when the vLAPIC is in
this state. Such interrupts are simply lost.

Introduce (IO-APIC) or re-use (MSI) a local variable to help
readability.

Fixes: 4fe21ad3712e ("This patch add virtual IOAPIC support for VMX guest")
Fixes: 85715f4bc7c9 ("MSI 5/6: add MSI support to passthrough HVM domain")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/vioapic.c
xen/arch/x86/hvm/vmsi.c