]> xenbits.xensource.com Git - libvirt.git/commit
storage: Add default mount options for fs/netfs storage pools
authorJohn Ferlan <jferlan@redhat.com>
Fri, 11 Jan 2019 15:53:35 +0000 (10:53 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 30 Jan 2019 00:15:20 +0000 (19:15 -0500)
commitf00cde7f1133fee96dc13a80d7f402c704346974
treeeb330798328e1bacea831863cf205c7ee7d1bb56
parentd0ba8d65530d120ec98c09480b0a10cd5868dcda
storage: Add default mount options for fs/netfs storage pools

https://bugzilla.redhat.com/show_bug.cgi?id=1584663

Modify the command generation to add some default options to the
fs/netfs storage pools based on the OS type. For Linux, it'll be
the "nodev, nosuid, noexec". For FreeBSD, it'll be "nosuid, noexec".
For others, just leave the options alone.

Modify the storagepoolxml2argvtest to handle the fact that the
same input XML could generate different output XML based on whether
Linux, FreeBSD, or other was being built.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
12 files changed:
src/storage/storage_util.c
tests/storagepoolxml2argvdata/pool-fs-freebsd.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-fs-linux.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-auto-freebsd.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-auto-linux.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-cifs-freebsd.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-cifs-linux.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-freebsd.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-gluster-freebsd.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-gluster-linux.argv [new file with mode: 0644]
tests/storagepoolxml2argvdata/pool-netfs-linux.argv [new file with mode: 0644]
tests/storagepoolxml2argvtest.c