]> xenbits.xensource.com Git - people/aperard/linux.git/commit
fs/ntfs3: Fix a possible null-pointer dereference in ni_clear()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Jan 2023 08:59:43 +0000 (16:59 +0800)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Mon, 27 Mar 2023 12:59:16 +0000 (16:59 +0400)
commitec275bf9693d19cc0fdce8436f4c425ced86f6e7
tree1477e6c89a6d9b9d46244ca513f765124563f6ef
parent6827d50b2c430c329af442b64c9176d174f56521
fs/ntfs3: Fix a possible null-pointer dereference in ni_clear()

In a previous commit c1006bd13146, ni->mi.mrec in ni_write_inode()
could be NULL, and thus a NULL check is added for this variable.

However, in the same call stack, ni->mi.mrec can be also dereferenced
in ni_clear():

ntfs_evict_inode(inode)
  ni_write_inode(inode, ...)
    ni = ntfs_i(inode);
    is_rec_inuse(ni->mi.mrec) -> Add a NULL check by previous commit
  ni_clear(ntfs_i(inode))
    is_rec_inuse(ni->mi.mrec) -> No check

Thus, a possible null-pointer dereference may exist in ni_clear().
To fix it, a NULL check is added in this function.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/frecord.c