]> xenbits.xensource.com Git - libvirt.git/commit
qemu: reject rather than hang on blockcommit of active layer
authorEric Blake <eblake@redhat.com>
Tue, 27 May 2014 23:07:08 +0000 (17:07 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 28 May 2014 16:41:58 +0000 (10:41 -0600)
commite6bcbcd32c70ae394e7b6a530012fe8b07a59b5d
tree2fc72de72247ed437e4282a10490de326d3b2fb0
parent110be4112f82f4cae920f17954c36a68c1a68aea
qemu: reject rather than hang on blockcommit of active layer

qemu 2.0 added the ability to commit the active layer, but slightly
differently than what libvirt had been anticipating in its
implementation of the virDomainBlockCommit call.  As a result, if
you attempt to do a 'virsh blockcommit $dom vda', qemu gets into a
state where it is waiting on libvirt to end the job, while libvirt
is waiting on qemu to end the job, and the guest is effectively
hung with regards to further commands for that block device.

I have patches coming down the pipeline that will add full support
for blockcommit of the active layer when coupled with qemu 2.0 or
later; but they depend on Peter's improvements to block job handling
and form enough of a new feature that they are not ready for
inclusion in the 1.2.5 release.  So for now, just reject the
attempt, rather than letting the user get stuck.  This is no worse
than the behavior of qemu 1.7 rejecting the job.

* src/qemu/qemu_driver.c (qemuDomainBlockCommit): Reject active
commit.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/qemu/qemu_driver.c