]> xenbits.xensource.com Git - xen.git/commit
x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max policies
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 28 Feb 2024 20:22:24 +0000 (20:22 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 1 Mar 2024 20:14:19 +0000 (20:14 +0000)
commite2d8a652251660c3252d92b442e1a9c5d6e6a1e9
tree6e2b05350e05cd733785c333b9e6047e13f1160b
parent5420aa165dfa5fe95dd84bb71cb96c15459935b1
x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max policies

The block in recalculate_cpuid_policy() predates the proper split between
default and max policies, and was a "slightly max for a toolstack which knows
about it" capability.  It didn't get transformed properly in Xen 4.14.

Because Xen will accept a VM with HTT/CMP_LEGACY seen, they should be visible
in the max polices.  Keep the default policy matching host settings.

This manifested as an incorrectly-rejected migration across XenServer's Xen
4.13 -> 4.17 upgrade, as Xapi is slowly growing the logic to check a VM
against the target max policy.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
xen/arch/x86/cpu-policy.c