]> xenbits.xensource.com Git - people/dwmw2/xen.git/commit
x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages
authorJan Beulich <jbeulich@suse.com>
Thu, 15 Nov 2018 15:42:25 +0000 (16:42 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 15 Nov 2018 15:42:25 +0000 (16:42 +0100)
commitd7bff2bc003cd5fd8c618b70c62b8fcfd9cd187e
tree80c9cf55cf87ac6879752ba4826404e6d296a571
parentf089fddd94101a710575d81207b21794c2ecd881
x86/HVM: __hvm_copy() should not write to p2m_ioreq_server pages

Commit 3bdec530a5 ("x86/HVM: split page straddling emulated accesses in
more cases") introduced a hvm_copy_to_guest_linear() attempt before
falling back to hvmemul_linear_mmio_write(). This is wrong for the
p2m_ioreq_server special case. That change widened a pre-existing issue
though: Other writes to such pages also need to be failed (or forced
through emulation), in particular hypercall buffer writes.

Reported-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/hvm.c