]> xenbits.xensource.com Git - libvirt.git/commit
conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew
authorJohn Ferlan <jferlan@redhat.com>
Sun, 3 Nov 2019 12:12:58 +0000 (07:12 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 6 Nov 2019 16:27:12 +0000 (11:27 -0500)
commitd343e8203d248635f5e7a0d86dd077f74d49e3af
tree36d9c5bc435cc3f3e918cb0eb9022d249d665ff3
parent18a1ce77b60cef9084c3bee01b2abb24f1c14586
conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew

Commit 17561eb36 modified the logic to check "if (!event)" for an
attribute that was not supposed to be passed as NULL.  This causes
the static checker/Coverity build to fail. Since the check is made,
alter the header.

Also add an error message since returning -1 without some sort of
error message as previously would have happened with the failed
VIR_STRDUP so that the eventual error doesn't get the default
for some reason message.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/conf/domain_event.c
src/conf/domain_event.h