]> xenbits.xensource.com Git - libvirt.git/commit
storage: unify permission formatting
authorMartin Kletzander <mkletzan@redhat.com>
Wed, 10 Dec 2014 12:54:10 +0000 (13:54 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 16 Dec 2014 14:47:56 +0000 (15:47 +0100)
commitd2632d60aa86f5f214eba2a10d338beb3b7722ca
tree322282d1ee7cb063a518e235dea2bf9537a720e2
parente3435caf6af41748204e542dee13ede8441d88c0
storage: unify permission formatting

Volume and pool formatting functions took different approaches to
unspecified uids/gids.  When unknown, it is always parsed as -1, but one
of the functions formatted it as unsigned int (wrong) and one as
int (better).  Due to that, our two of our XML files from tests cannot
be parsed on 32-bit machines.

RNG schema needs to be modified as well, but because both
storagepool.rng and storagevol.rng need same schema for permission
element, save some space by moving it to storagecommon.rng.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
docs/schemas/storagecommon.rng
docs/schemas/storagepool.rng
docs/schemas/storagevol.rng
src/conf/storage_conf.c
tests/storagevolxml2xmlin/vol-gluster-dir-neg-uid.xml [new file with mode: 0644]
tests/storagevolxml2xmlout/vol-gluster-dir-neg-uid.xml [new file with mode: 0644]
tests/storagevolxml2xmlout/vol-gluster-dir.xml
tests/storagevolxml2xmlout/vol-sheepdog.xml
tests/storagevolxml2xmltest.c