]> xenbits.xensource.com Git - xen.git/commit
xen/ELF: Fix ELF32 PRI formatters
authorAndrew Cooper <andrew.cooper3@citrix.com>
Sun, 16 Apr 2023 00:29:09 +0000 (01:29 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 19 Apr 2023 14:55:29 +0000 (15:55 +0100)
commitcfa2bb82c01f0c656804cedd8f44eb2a99a2b5bc
tree07368ca8a20fc3c8d806b0e125aeb70e086b27b1
parent569632a5832c02bd84790e0411940b8d3150fa17
xen/ELF: Fix ELF32 PRI formatters

It is rude to hide width formatting inside a PRI* macro, doubly so when it's
only in one bitness of the macro.

However its fully buggy when all the users use %#"PRI because then it expands
to the common trap of %#08x which does not do what the author intends.

Switch the 32bit ELF PRI formatters to use plain integer PRI's, just like on
the 64bit side already.  No practical change.

Fixes: 7597fabca76e ("livepatch: Include sizes when an mismatch occurs")
Fixes: 380b229634f8 ("xsplice: Implement payload loading")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
xen/include/xen/elfstructs.h