]> xenbits.xensource.com Git - libvirt.git/commit
network: delay global firewall setup if no networks are running
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 21 May 2019 11:40:13 +0000 (12:40 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 23 May 2019 15:29:48 +0000 (16:29 +0100)
commitc6cbe18771c832fba02e8edda250eb67d4afe5a5
treefd0f920cbd3e9156d2585460c0cf0ca20ee366d9
parent3b66bd9aa1bc463f7123f7b966e5c38e72d650f7
network: delay global firewall setup if no networks are running

Creating firewall rules for the virtual networks causes the kernel to
load the conntrack module. This imposes a significant performance
penalty on Linux network traffic. Thus we want to only take that hit if
we actually have virtual networks running.

We need to create global firewall rules during startup in order to
"upgrade" rules for any running networks created by older libvirt.
If no running networks are present though, we can safely delay setup
until the time we actually start a network.

Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/network/bridge_driver.c
src/network/bridge_driver_linux.c
src/network/bridge_driver_nop.c
src/network/bridge_driver_platform.h
tests/networkxml2firewalldata/base.args [new file with mode: 0644]
tests/networkxml2firewalltest.c