]> xenbits.xensource.com Git - libvirt.git/commit
numa: split util/ and conf/ and support non-contiguous nodesets
authorMartin Kletzander <mkletzan@redhat.com>
Thu, 6 Nov 2014 11:16:54 +0000 (12:16 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Thu, 6 Nov 2014 14:13:55 +0000 (15:13 +0100)
commitc63ef0452b299899fbe55559b8d9e8818e91566d
tree2d95ed3f9d54cd5d932333e88d9eacb8d37ad03b
parent4601594c4db136a6761722b69ccbc92073dbaac3
numa: split util/ and conf/ and support non-contiguous nodesets

This is a reaction to Michal's fix [1] for non-NUMA systems that also
splits out conf/ out of util/ because libvirt_util shouldn't require
libvirt_conf if it is the other way around.  This particular use case
worked, but we're trying to avoid it as mentioned [2], many times.

The only functions from virnuma.c that needed numatune_conf were
virDomainNumatuneNodesetIsAvailable() and virNumaSetupMemoryPolicy().
The first one should be in numatune_conf as it works with
virDomainNumatune, the second one just needs nodeset and mode, both of
which can be passed without the need of numatune_conf.

Apart from fixing that, this patch also fixes recently added
code (between commits d2460f85^..5c8515620) that doesn't support
non-contiguous nodesets.  It uses new function
virNumaNodesetIsAvailable(), which doesn't need a stub as it doesn't use
any libnuma functions, to check if every specified nodeset is available.

[1] https://www.redhat.com/archives/libvir-list/2014-November/msg00118.html
[2] http://www.redhat.com/archives/libvir-list/2011-June/msg01040.html

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/numatune_conf.c
src/conf/numatune_conf.h
src/libvirt_private.syms
src/lxc/lxc_controller.c
src/qemu/qemu_command.c
src/qemu/qemu_process.c
src/util/virnuma.c
src/util/virnuma.h
tests/qemuxml2argvmock.c