]> xenbits.xensource.com Git - xen.git/commit
libxl: Fix error path in libxl_device_events_handler
authorIan Jackson <ian.jackson@eu.citrix.com>
Wed, 19 Feb 2014 14:03:29 +0000 (14:03 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 12 Mar 2014 14:11:31 +0000 (14:11 +0000)
commitc566ab68af7da089ae2b0ff664d02a93a0647584
treedef0cb03cc5cbf917d1d62516a71890ea9e126c5
parentc11995ff37caf438d3e93d843e5078452ad1b298
libxl: Fix error path in libxl_device_events_handler

libxl_device_events_handler would fail to call AO_ABORT if it failed;
instead it would simply return rc.  (This leaves the egc etc. from the
now-abolished stack frame potentially live, and leaves the ctx
locked.)

In xl, this is of no consequence, because xl will immediately exit in
this situation.  This is very likely to be true in any other callers
(of which we don't know of any, anyway).

Coverity-ID: 1181840
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
CC: coverity@xenproject.org
tools/libxl/libxl.c