]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Avoid using stale data in virDomainGetBlockInfo
authorJiri Denemark <jdenemar@redhat.com>
Fri, 20 Dec 2013 13:50:02 +0000 (14:50 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 7 Jan 2014 15:10:02 +0000 (16:10 +0100)
commitb799259583bd65c0b2f5042e6c3ff19637ade881
treeb7c8661ff376acb27090b0bb54451da8514dab4d
parentdb86da5ca2109e4006c286a09b6c75bfe10676ad
qemu: Avoid using stale data in virDomainGetBlockInfo

CVE-2013-6458

Generally, every API that is going to begin a job should do that before
fetching data from vm->def. However, qemuDomainGetBlockInfo does not
know whether it will have to start a job or not before checking vm->def.
To avoid using disk alias that might have been freed while we were
waiting for a job, we use its copy. In case the disk was removed in the
meantime, we will fail with "cannot find statistics for device '...'"
error message.
src/qemu/qemu_driver.c