]> xenbits.xensource.com Git - people/royger/xen.git/commit
x86/shadow: Drop dubious lastpage diagnostic
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 20 Jan 2023 11:01:52 +0000 (11:01 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 20 Jan 2023 19:39:32 +0000 (19:39 +0000)
commitb5d8b03db136dca2c7e755cd227265b5be451c88
treea3f1c8a7ffcb9ce9969212b4a4302745ab20440b
parent848ca4e75f972e1d6ddae110965b2cc24997544f
x86/shadow: Drop dubious lastpage diagnostic

This is a global variable (actually 3, one per GUEST_PAGING_LEVEL), operated
on using atomics only (with no regard to what else shares the same cacheline),
which emits a diagnostic (in debug builds only) without changing any program
behaviour.

It is presumably left-over debugging, as it interlinks the behaviour of all
vCPUs in chronological order.  Based on the read-only p2m types, this
diagnostic can be tripped by entirely legitimate guest behaviour.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/mm/shadow/multi.c