]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Refuse blockjobs on disk bus='sd' with -blockdev
authorPeter Krempa <pkrempa@redhat.com>
Fri, 17 Apr 2020 09:09:58 +0000 (11:09 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 12 May 2020 04:55:00 +0000 (06:55 +0200)
commitb50a8354f6d371c753867f1729a9ad492f3105f1
tree75a7e9fb38add36d204f61a967ed3b4d7b3a7461
parent59a3adbcf268192960e9b52fddc08c5c3b94bfd7
qemu: Refuse blockjobs on disk bus='sd' with -blockdev

We still have to use -drive to instantiate sd disks. Combining that with
the new logic for blockjobs would be very complicated and not worth it
given that 'sd' cards work only on few rarely used machine types of
non-common architectures and libvirt didn't implement support for 'sd'
bus controllers. This will allow us to use -blockdev for other kinds on
such machines while sacrificing block jobs.

Note: this is currently no-op as we mask-out the QEMU_CAPS_BLOCKDEV
capability if any of the disks has bus='sd'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_backup.c
src/qemu/qemu_checkpoint.c
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
src/qemu/qemu_driver.c