]> xenbits.xensource.com Git - libvirt.git/commit
blockjob: wait for pivot to complete
authorEric Blake <eblake@redhat.com>
Mon, 14 Jul 2014 16:13:18 +0000 (10:13 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 16 Jul 2014 13:23:24 +0000 (07:23 -0600)
commit97c59b9c46f915c48cd5db96ada40f060553bcae
treea815a7b9bd6162f93b9791efd8806448ff5b3128
parenta0b5ace28c78c6afa9f37665cdb41caa778a229f
blockjob: wait for pivot to complete

https://bugzilla.redhat.com/show_bug.cgi?id=1119173 documents that
commit eaba79d was flawed in the implementation of the
VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag when it comes to completing
a blockcopy.  Basically, the qemu pivot action is async (the QMP
command returns immediately, but the user must wait for the
BLOCK_JOB_COMPLETE event to know that all I/O related to the job
has finally been flushed), but the libvirt command was documented
as synchronous by default.  As active block commit will also be
using this code, it is worth fixing now.

* src/qemu/qemu_driver.c (qemuDomainBlockJobImpl): Don't skip wait
loop after pivot.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/qemu/qemu_driver.c