]> xenbits.xensource.com Git - xen.git/commit
x86/shadow: don't enable shadow mode with too small a shadow allocation (part 2)
authorJan Beulich <jbeulich@suse.com>
Thu, 5 Sep 2019 07:56:42 +0000 (09:56 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 5 Sep 2019 07:56:42 +0000 (09:56 +0200)
commit8b25551baa3307af0aa1ef8f7f43403f01c2c5d7
treedab49481bdb20f7c0b3771a294fb6d0c95b8c0fc
parent039e70668a12f1fccdd89058ac3e9755733d9082
x86/shadow: don't enable shadow mode with too small a shadow allocation (part 2)

Commit 2634b997af ("x86/shadow: don't enable shadow mode with too small
a shadow allocation") was incomplete: The adjustment done there to
shadow_enable() is also needed in shadow_one_bit_enable(). The (new)
problem report was (apparently) a failed PV guest migration followed by
another migration attempt for that same guest. Disabling log-dirty mode
after the first one had left a couple of shadow pages allocated (perhaps
something that also wants fixing), and hence the second enabling of
log-dirty mode wouldn't have allocated anything further.

Reported-by: James Wang <jnwang@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Tim Deegan <tim@xen.org>
xen/arch/x86/mm/shadow/common.c