]> xenbits.xensource.com Git - libvirt.git/commit
storage: fix RNG validation of gluster via netfs
authorEric Blake <eblake@redhat.com>
Tue, 12 Nov 2013 23:35:36 +0000 (16:35 -0700)
committerEric Blake <eblake@redhat.com>
Wed, 13 Nov 2013 19:10:00 +0000 (12:10 -0700)
commit887dd3625b71e6d71aa362a46cf6075b13cb1bb5
treee7480590b0ed71ed7313b3c3a3036b0a50adf658
parent8d7800a5542ec1b103cd159f8998296e4ce64ee5
storage: fix RNG validation of gluster via netfs

While trying to compare netfs against my new gluster pool, I
discovered two things:

virt-xml-validate chokes on valid xml produced by 'virsh pool-dumpxml'
[yet another reason that ALL patches that add new xml should be adding
corresponding tests]

When using glusterfs FUSE mounts, you cannot access a subdirectory
of a gluster volume.  The recommended workaround in the gluster
community is to mount the volume to an intermediate location, then
bind-mount the desired subdirectory to the final location.  Maybe
we should teach libvirt to do bind-mounting, but for now I chose to
just document the limitation.

* docs/storage.html.in: Improve documentation.
* docs/schemas/storagepool.rng (sourcefmtnetfs): Allow all
formats, and drop redundant info-vendor.
* tests/storagepoolxml2xmltest.c (mymain): New test.
* tests/storagepoolxml2xmlin/pool-netfs-gluster.xml: New file.
* tests/storagepoolxml2xmlout/pool-netfs-gluster.xml: Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
docs/schemas/storagepool.rng
docs/storage.html.in
tests/storagepoolxml2xmlin/pool-netfs-gluster.xml [new file with mode: 0644]
tests/storagepoolxml2xmlout/pool-netfs-gluster.xml [new file with mode: 0644]
tests/storagepoolxml2xmltest.c