]> xenbits.xensource.com Git - xen.git/commit
x86/irq: fix reporting of spurious i8259 interrupts
authorRoger Pau Monné <roger.pau@citrix.com>
Wed, 30 Aug 2023 08:03:53 +0000 (10:03 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 30 Aug 2023 08:03:53 +0000 (10:03 +0200)
commit709f6c8ce6422475c372e67507606170a31ccb65
tree146132ca7d45740bd844eb7469fe01c7d0ca100d
parent8c01f267eff3d6c1ea04273e9885bf6d2fda1c44
x86/irq: fix reporting of spurious i8259 interrupts

The return value of bogus_8259A_irq() is wrong: the function will
return `true` when the IRQ is real and `false` when it's a spurious
IRQ.  This causes the "No irq handler for vector ..." message in
do_IRQ() to be printed for spurious i8259 interrupts which is not
intended (and not helpful).

Fix by inverting the return value of bogus_8259A_irq().

Fixes: 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more quietly')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/i8259.c