]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Rewrite chardev startup code to use qemuFDPass
authorPeter Krempa <pkrempa@redhat.com>
Wed, 2 Feb 2022 16:31:29 +0000 (17:31 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 14 Feb 2022 12:14:00 +0000 (13:14 +0100)
commit6d161bcc6031cf48f0c70c0a746d82b2838c33f9
tree440db9bf0de2c89740938bc53693a042ee9bcf56
parent38edcca114e0747366a7d5c7ac170bd57665a3eb
qemu: Rewrite chardev startup code to use qemuFDPass

Rewrite the parts which already pass FDs via fdset or directly to use
the new infrastructure.

Apart from simpler code this also adds the appropriate names to the fds
in the fdsets which will allow us to properly remove the fdsets won
hot-unplug of chardevs, which we didn't do for now and resulted in
leaking the FDs.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
14 files changed:
src/qemu/qemu_command.c
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
src/qemu/qemu_process.c
tests/qemuxml2argvdata/aarch64-pci-serial.args
tests/qemuxml2argvdata/name-escape.x86_64-2.11.0.args
tests/qemuxml2argvdata/name-escape.x86_64-latest.args
tests/qemuxml2argvdata/serial-file-chardev.args
tests/qemuxml2argvdata/serial-file-chardev.x86_64-latest.args
tests/qemuxml2argvdata/serial-file-log.args
tests/qemuxml2argvdata/serial-file-log.x86_64-latest.args
tests/qemuxml2argvdata/serial-many-chardev.args
tests/qemuxml2argvdata/serial-many-chardev.x86_64-latest.args
tests/qemuxml2argvtest.c