]> xenbits.xensource.com Git - xen.git/commit
x86/vmx: Partially revert "x86/vmx: implement Notify VM Exit"
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 18 Jan 2023 19:20:05 +0000 (19:20 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 20 Jan 2023 19:39:32 +0000 (19:39 +0000)
commit5f08bc9404c7cfa8131e262c7dbcb4d96c752686
tree7a8d0349cbb1ec8c9ab3a8ccb6ffa7ee016f1364
parentb5d8b03db136dca2c7e755cd227265b5be451c88
x86/vmx: Partially revert "x86/vmx: implement Notify VM Exit"

The original patch tried to do two things - implement VMNotify, and
re-optimise VT-x to not intercept #DB/#AC by default.

The second part is buggy in multiple ways.  Both GDBSX and Introspection need
to conditionally intercept #DB, which was not accounted for.  Also, #DB
interception has nothing at all to do with cpu_has_monitor_trap_flag.

Revert the second half, leaving #DB/#AC intercepted unilaterally, but with
VMNotify active by default when available.

Fixes: 573279cde1c4 ("x86/vmx: implement Notify VM Exit")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
xen/arch/x86/hvm/vmx/vmcs.c
xen/arch/x86/hvm/vmx/vmx.c