]> xenbits.xensource.com Git - xen.git/commit
x86/vpmu: Remove unnecessary call to do_interrupt()
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Tue, 24 Oct 2017 23:30:20 +0000 (19:30 -0400)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 27 Oct 2017 13:32:38 +0000 (14:32 +0100)
commit5e2bfc23f7c9a60c01a02c619e1f3d7456ce0e93
tree458583013ab91ec05a4f2cc6e524f67b9f990f69
parent65ab53de34851243fb7793ebf12fd92a65f84ddd
x86/vpmu: Remove unnecessary call to do_interrupt()

This call was left during PVHv1 removal (commit 33e5c32559e1 ("x86:
remove PVHv1 code")):

-        if ( is_pvh_vcpu(sampling) &&
-             !(vpmu_mode & XENPMU_MODE_ALL) &&
+        if ( !(vpmu_mode & XENPMU_MODE_ALL) &&
              !vpmu->arch_vpmu_ops->do_interrupt(regs) )
             return;

As result of this extra call VPMU no longer works for PV guests on Intel
because we effectively lose value of MSR_CORE_PERF_GLOBAL_STATUS.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Julien Grall <julien.grall@linaro.org>
xen/arch/x86/cpu/vpmu.c