]> xenbits.xensource.com Git - libvirt.git/commit
libxl: fix memory corruption introduced by commit b55cc5f4e
authorJim Fehlig <jfehlig@suse.com>
Mon, 25 Aug 2014 22:46:00 +0000 (16:46 -0600)
committerJim Fehlig <jfehlig@suse.com>
Mon, 25 Aug 2014 23:35:12 +0000 (17:35 -0600)
commit4dfc34c301206d50d41b3122a6dbfe6e687afd0f
tree77e7e3fbddc220af510fa8c94379ac6f6c47b98e
parent28de556dde1907a4e0555b3cf7afc0c398d0accd
libxl: fix memory corruption introduced by commit b55cc5f4e

Commit b55cc5f4e did a shallow copy of libxl_{sdl,vnc}_info from the
domain config to the build info, which resulted in double-freeing
strings contained in the structures during cleanup, which later
resulted in a libvirtd crash.  Fix by performing a deep copy of the
structure, VIR_STRDUP'ing embedded strings instead of simply copying
their pointers.

Fixes the following issue reported on the libvirt dev list

https://www.redhat.com/archives/libvir-list/2014-August/msg01112.html
src/libxl/libxl_conf.c