]> xenbits.xensource.com Git - xen.git/commit
x86: fix return value checks of set_guest_{machinecheck,nmi}_trapbounce 4.11.0-rc3
authorJan Beulich <jbeulich@suse.com>
Thu, 3 May 2018 15:35:51 +0000 (17:35 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 3 May 2018 15:35:51 +0000 (17:35 +0200)
commit4611f529c0e39493a3945641cc161967a864d6b5
tree54a4d46e44e4832a5452bde00e474ea65ba588c1
parent9a36de177c16d6423a07ad61f1c7af5274769aae
x86: fix return value checks of set_guest_{machinecheck,nmi}_trapbounce

Commit 0142064421 ("x86/traps: move set_guest_{machine,nmi}_trapbounce")
converted the functions' return types from int to bool without also
correcting the checks in assembly code: The ABI does not guarantee sub-
32-bit return values to be promoted to 32 bits.

Take the liberty and also adjust the number of spaces used in the compat
code, such that both code sequences end up similar (they already are in
the non-compat case).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
xen/arch/x86/x86_64/compat/entry.S
xen/arch/x86/x86_64/entry.S