]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Reject unsupported tuning in session mode
authorMartin Kletzander <mkletzan@redhat.com>
Thu, 27 Feb 2014 12:10:32 +0000 (13:10 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Thu, 6 Mar 2014 14:29:07 +0000 (15:29 +0100)
commit45ad1adb4a5ae5ce46287c570e87abab6ffe62d6
treea62e9b3d4cb606c56ee72ab11b63a37ad296cd38
parente5cd28c02385d5643df9e3261a54353b772ab342
qemu: Reject unsupported tuning in session mode

When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.

When setting with API, virsh, an error is reported, but only due to
the fact that no cgroups are mounted (priv->cgroup == NULL).

Given the above it seems reasonable to reject such unsupported
settings.

This patch effectively changes the error message from:

$ virsh -c qemu:///session schedinfo dummy
Scheduler      : Unknown
error: Requested operation is not valid: cgroup CPU controller is not mounted

to:

$ virsh -c qemu:///session schedinfo dummy
Scheduler      : Unknown
error: Operation not supported: CPU tuning is not available in session mode

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1023366

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_driver.c