]> xenbits.xensource.com Git - libvirt.git/commit
util: get rid of virGetEnv{Allow,Block}SUID functions
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 1 Aug 2019 12:35:56 +0000 (13:35 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 7 Aug 2019 15:54:02 +0000 (16:54 +0100)
commit2b0d597670fb5504b7ad1411c31b8af1d3016c1b
tree0829491aea08d79b7187abc7667a6f53e2544676
parentfcf93c3ee0ed24d282da37713f4e8be0ce79a7c7
util: get rid of virGetEnv{Allow,Block}SUID functions

Now that 100% of libvirt code is forbidden in a SUID environment,
we no longer need to worry about whether env variables are
trustworthy or not. The virt-login-shell setuid program, which
does not link to any libvirt code, will purge all environment
variables, except $TERM, before invoking the virt-login-shell-helper
program which uses libvirt.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
22 files changed:
cfg.mk
src/libvirt-admin.c
src/libvirt.c
src/libvirt_private.syms
src/network/leaseshelper.c
src/qemu/qemu_firmware.c
src/remote/remote_driver.c
src/rpc/virnetlibsshsession.c
src/rpc/virnettlscontext.c
src/util/virauth.c
src/util/vircommand.c
src/util/virfile.c
src/util/virlease.c
src/util/virlog.c
src/util/virsystemd.c
src/util/virutil.c
src/util/virutil.h
src/vbox/vbox_XPCOMCGlue.c
src/vbox/vbox_common.c
tools/virsh.c
tools/virt-login-shell-helper.c
tools/vsh.c