]> xenbits.xensource.com Git - people/pauldu/xen.git/commit
xen: Fix inconsistent callers of panic()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 29 Aug 2018 16:39:10 +0000 (16:39 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 11 Sep 2018 09:33:46 +0000 (10:33 +0100)
commit25eb5eec796f5a965fda37c2968b3b7dd738eb72
treef859a03904a62fff63c37dc7371d876132b49b7f
parent66b245d9eaebfef710148d410ae97a2eaedc3170
xen: Fix inconsistent callers of panic()

Callers are inconsistent with whether they pass a newline to panic(),
including adjacent calls in the same function using different styles.

painc() not expecting a newline is inconsistent with most other printing
functions, which is most likely why we've gained so many inconsistencies.

Switch panic() to expect a newline, and update all callers which currently
lack a newline to include one.

This actually reduces the size of .rodata (0x07e3e8 down to 0x07e3a8) because
a number of strings are passed to both panic() and printk().  As they
previously differed by \n alone, they couldn't be merged.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <julien.grall@arm.com>
48 files changed:
xen/arch/arm/arm32/vfp.c
xen/arch/arm/arm64/traps.c
xen/arch/arm/domain_build.c
xen/arch/arm/gic-v2.c
xen/arch/arm/gic-v3-its.c
xen/arch/arm/gic-v3.c
xen/arch/arm/gic.c
xen/arch/arm/kernel.c
xen/arch/arm/mm.c
xen/arch/arm/p2m.c
xen/arch/arm/platform.c
xen/arch/arm/platforms/xgene-storm.c
xen/arch/arm/setup.c
xen/arch/arm/smpboot.c
xen/arch/arm/time.c
xen/arch/arm/traps.c
xen/arch/arm/vgic/vgic.c
xen/arch/x86/acpi/power.c
xen/arch/x86/alternative.c
xen/arch/x86/apic.c
xen/arch/x86/cpu/mcheck/mce.c
xen/arch/x86/guest/xen.c
xen/arch/x86/hvm/dom0_build.c
xen/arch/x86/hvm/svm/intr.c
xen/arch/x86/io_apic.c
xen/arch/x86/mm/mm-locks.h
xen/arch/x86/mpparse.c
xen/arch/x86/numa.c
xen/arch/x86/pv/dom0_build.c
xen/arch/x86/pv/shim.c
xen/arch/x86/setup.c
xen/arch/x86/smpboot.c
xen/arch/x86/tboot.c
xen/arch/x86/time.c
xen/arch/x86/traps.c
xen/arch/x86/x86_64/mm.c
xen/arch/x86/x86_64/traps.c
xen/common/domain.c
xen/common/gunzip.c
xen/common/schedule.c
xen/common/ubsan/ubsan.c
xen/common/warning.c
xen/drivers/char/console.c
xen/drivers/passthrough/iommu.c
xen/drivers/passthrough/pci.c
xen/drivers/passthrough/vtd/dmar.h
xen/drivers/passthrough/vtd/iommu.c
xen/xsm/flask/hooks.c