]> xenbits.xensource.com Git - people/sstabellini/xen-unstable.git/.git/commit
tools/libxl: Reposition build_pre() logic between architectures
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 20 Dec 2019 17:13:41 +0000 (17:13 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Sat, 25 Jan 2020 18:43:32 +0000 (18:43 +0000)
commit1e9bc407cf0732654916ca4311ca1972495d5cbe
tree705f32a6f92f59393144923c936a632a0bac4420
parent8142e165f4370cb9d24af16e14259b879736e7c7
tools/libxl: Reposition build_pre() logic between architectures

The call to xc_domain_disable_migrate() is made only from x86, while its
handling in Xen is common.  Move it to the libxl__build_pre().

hvm_set_conf_params(), hvm_set_viridian_features(),
hvm_set_mca_capabilities(), and the altp2m logic is all in common code (parts
ifdef'd) but despite this, is all actually x86 specific, as least as currently
implemented in Xen.  Some concepts (nested virt, altp2m) are common in
principle, but need their interface changing to be part of domain_create, and
are not expecting to survive in their current HVM_PARAM form.

Move it all into x86 specific code, and fold all of the xc_hvm_param_set()
calls together into hvm_set_conf_params() in a far more coherent way.

Finally - ensure that all hypercalls have their return values checked.

No practical change in constructed domains.  Fewer useless hypercalls now to
construct an ARM guest.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wl@xen.org>
tools/libxl/libxl_dom.c
tools/libxl/libxl_x86.c