]> xenbits.xensource.com Git - xen.git/commit
x86emul: fix 3-operand IMUL
authorJan Beulich <jbeulich@suse.com>
Tue, 18 Dec 2018 13:27:09 +0000 (14:27 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 18 Dec 2018 13:27:09 +0000 (14:27 +0100)
commit19232b378fab04997c0612e5c19e82c29b59d99e
tree5fed7cba2a939ee2102c1f277987d82e38c54f9d
parent95d99966713da79c5cc83748767b2cb3d89cb127
x86emul: fix 3-operand IMUL

While commit 75066cd4ea ("x86emul: fix {,i}mul and {,i}div") indeed did
as its title says, it broke the 3-operand form by uniformly using AL/AX/
EAX/RAX as second source operand. Fix this and add tests covering both
cases.

Reported-by: Andrei Lutas <vlutas@bitdefender.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
tools/tests/x86_emulator/test_x86_emulator.c
xen/arch/x86/x86_emulate/x86_emulate.c