]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
remote: fix dom->id after virDomainCreateWithFlags
authorMarek Marczykowski <marmarek@invisiblethingslab.com>
Thu, 23 May 2013 00:01:30 +0000 (02:01 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 23 May 2013 13:07:16 +0000 (15:07 +0200)
commit03d813bbcd7b4a18360105500672b84d985dd889
treea84a2bb7ac345974e60bfc4df4fc3c985cc2003c
parent47562282473a75b1864375ee8e5f8676438d6986
remote: fix dom->id after virDomainCreateWithFlags

The same issue as (already fixed) in virDomainCreate -
REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only
-1 on error or 0 on success.

Besides this one fix it is more general problem - local domain object
ID can desynchronize with the real one, for example in case of another
client creates/destroys domain in the meantime. Perhaps virDomainGetID
should be called remotely (with all performance implications...)? Or
some event-based notification used?

Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
src/remote/remote_driver.c
src/remote/remote_protocol.x