Lars Kurth [Thu, 12 Dec 2019 16:04:04 +0000 (16:04 +0000)]
Improvements to CoC
Changes since v2:
code-review-guide.md
* Extend introduction
* Add "Code Review Workflow" covering
- "Workflow from a Reviewer's Perspective"
- "Workflow from an Author's Perspective"
- "Problematic Patch Reviews"
TODO: find suitable examples on how to structure/describe good patch series
communication-practice.md
* Fix typos
* Extended "Verbose vs. terse"
* Added "Clarity over Verbosity"
* Broke "Identify the severity of an issue or disagreement" into two chapters
- "Identify the severity and optionality of review comments" and made
clarifications
- "Identify the severity of a disagreement"
- Expanded "Prioritize significant flaws"
* Added "Reviewers: Take account of previous reviewer(s) comments"
* Added prefixes such as "Reviewers:" where appropriate
resolving-disagreement.md
* Fix typos
* Add section: "Issue: Multiple ways to solve a problem"
Lars Kurth [Thu, 12 Dec 2019 16:04:04 +0000 (16:04 +0000)]
Improvements to CoC
Changes since v2:
code-review-guide.md
* Extend introduction
* Add Code Review Workflow covering
- Workflow from a Reviewer's Perspective
- Workflow from an Author's Perspective
- Problematic Patch Reviews
TODO: find suitable examples on how to structure/describe good patch series
communication-practice.md
* Fix typos
* Extended "Verbose vs. terse"
* Added "Clarity over Verbosity"
* Broke "Identify the severity of an issue or disagreement" into two chapters
- "Identify the severity and optionality of review comments" and made
clarifications
- "Identify the severity of a disagreement"
- Expanded "Prioritize significant flaws"
* Added "Reviewers: Take account of previous reviewer(s) comments"
* Added prefixes such as "Reviewers:" where appropriate
Lars Kurth [Thu, 26 Sep 2019 18:56:29 +0000 (19:56 +0100)]
Add guide on Communication Best Practice
This guide covers the bulk on Best Practice related to code review
It primarily focusses on code review interactions
It also covers how to deal with Misunderstandings and Cultural
Differences
Lars Kurth [Thu, 26 Sep 2019 18:55:50 +0000 (19:55 +0100)]
Add Code Review Guide
This document highlights what reviewers such as maintainers and committers look
for when reviewing code. It sets expectations for code authors and provides
a framework for code reviewers.
Lars Kurth [Thu, 26 Sep 2019 18:54:38 +0000 (19:54 +0100)]
Add Communication Guide
This document is a portal page that lays out our gold standard,
best practices for some common situations and mechanisms to help
resolve issues that can have a negative effect on our community.
Lars Kurth [Thu, 26 Sep 2019 18:45:02 +0000 (19:45 +0100)]
Xen Project Code of Conduct
Specific changes to the baseline:
* Replace list of positive behaviors with link to separate process
* Replace maintainers with project leadership
(except in our pledge where maintainers is more appropriate)
* Add 'of all sub-projects' to clarify scope of CoC
* Rename Enforcement
* Replace "project team" with "Conduct Team members"
* Add e-mail alias
* Add section on contacting individual Conduct Team members
* Add section on Conduct Team members
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
Chagges since v1:
* Addressed newline changes