]> xenbits.xensource.com Git - libvirt.git/log
libvirt.git
15 years agoAdd API for issuing 'pci_add host' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 15:15:51 +0000 (16:15 +0100)]
Add API for issuing 'pci_add host' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  API qemuMonitorAddPCIHostDevice()
* src/qemu/qemu_driver.c: Switch to using qemuMonitorAddPCIHostDevice()
  for PCI host device hotplug

15 years agoAdd APIs for sending 'usb_add' command for host devices
Daniel P. Berrange [Wed, 23 Sep 2009 15:04:55 +0000 (16:04 +0100)]
Add APIs for sending 'usb_add' command for host devices

One API adds an exact device based on bus+dev, the other adds
any device matching vendor+product

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  qemuMonitorAddUSBDeviceExact() and qemuMonitorAddUSBDeviceMatch()
  commands.
* src/qemu/qemu_driver.c: Switch over to using the new
    qemuMonitorAddUSBDeviceExact() and qemuMonitorAddUSBDeviceMatch()

15 years agoAdd API for using 'usb_add' for disk devices
Daniel P. Berrange [Wed, 23 Sep 2009 14:38:43 +0000 (15:38 +0100)]
Add API for using 'usb_add' for disk devices

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  qemuMonitorAddUSBDisk() API
* src/qemu/qemu_driver.c: Switch USB disk hotplug to the new
  src/qemu/qemu_driver.c API.

15 years agoAdd API for issuing 'migrate' command with exec protocol
Daniel P. Berrange [Wed, 23 Sep 2009 14:23:47 +0000 (15:23 +0100)]
Add API for issuing 'migrate' command with exec protocol

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  qemuMonitorMigrateToCommand() API
* src/qemu/qemu_driver.c: Switch over to using the
  qemuMonitorMigrateToCommand() API for core dumps and save
  to file APIs

15 years agoAdd API for issuing a 'migrate' monitor command for TCP
Daniel P. Berrange [Wed, 23 Sep 2009 13:48:49 +0000 (14:48 +0100)]
Add API for issuing a 'migrate' monitor command for TCP

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new API
  qemuMonitorMigrateToHost() for doing TCP migration
* src/qemu/qemu_driver.c: Convert to use qemuMonitorMigrateToHost().
  Also handle proper URIs (tcp:// as well as tcp:)

15 years agoAdd API for running 'info migration' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 13:27:12 +0000 (14:27 +0100)]
Add API for running 'info migration' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  qemuMonitorGetMigrationStatus() command.
* src/qemu/qemu_driver.c: Use new qemuMonitorGetMigrationStatus()
  command to check completion status.

15 years agoAdd API for issuing the 'migrate_set_speed' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 12:57:56 +0000 (13:57 +0100)]
Add API for issuing the 'migrate_set_speed' monitor command

* src/qemu/qemu_driver.c: Use new qemuMonitorSetMigrationSpeed()
  API during migration
* src/qemu/qemu_monitor.h, src/qemu/qemu_monitor.c: Add new
  qemuMonitorSetMigrationSpeed() API

15 years agoAdd API for issuing 'info blockstats' command
Daniel P. Berrange [Wed, 23 Sep 2009 12:51:05 +0000 (13:51 +0100)]
Add API for issuing 'info blockstats' command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add a new
  qemuMonitorGetBlockStatsInfo() command
* src/qemu/qemu_driver.c: Remove directly use of blockstats in
  favour of calling qemuMonitorGetBlockStatsInfo()

15 years agoAdd APIs for issuing 'memsave' and 'pmemsave' monitor commands
Daniel P. Berrange [Wed, 23 Sep 2009 12:33:45 +0000 (13:33 +0100)]
Add APIs for issuing 'memsave' and 'pmemsave' monitor commands

* src/qemu/qemu_monitor.h, src/qemu/qemu_monitor.c: Add new APIs
  qemuMonitorSaveVirtualMemory() and qemuMonitorSavePhysicalMemory()
* src/qemu/qemu_driver.c: Use the new qemuMonitorSaveVirtualMemory()
  and qemuMonitorSavePhysicalMemory() APIs

15 years agoAdd APIs for issuing 'eject' and 'change dev' monitor commands
Daniel P. Berrange [Wed, 23 Sep 2009 11:51:59 +0000 (12:51 +0100)]
Add APIs for issuing 'eject' and 'change dev' monitor commands

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new APis
  qemuMonitorChangeMedia and qemuMonitorEjectMedia. Pull in code
  for qemudEscape
* src/qemu/qemu_driver.c: Remove code that directly issues 'eject'
  and 'change' commands in favour of API calls.

15 years agoAdd API for issuing 'balloon' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 11:35:10 +0000 (12:35 +0100)]
Add API for issuing 'balloon' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add new
  qemuMonitorSetBalloon() based on existing code in
  qemudDomainSetMemoryBalloon
* src/qemu/qemu_driver.c: Remove use of qemudDomainSetMemoryBalloon()
  in favour of qemuMonitorSetBalloon(). Fix error code when balloon
  is not supported

15 years agoAdd API for running 'info balloon' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 11:29:39 +0000 (12:29 +0100)]
Add API for running 'info balloon' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Pull old
  qemudDomainGetMemoryBalloon() code into a new method called
  qemuMonitorGetBalloonInfo()
* src/qemu/qemu_driver.c: Update to call qemuMonitorGetBalloonInfo()
  and remove qemudDomainGetMemoryBalloon().

15 years agoAdd API for the 'system_powerdown' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 11:21:00 +0000 (12:21 +0100)]
Add API for the 'system_powerdown' monitor command

* src/qemu/qemu_driver.c: Remove use of 'system_powerdown'
* src/qemu/qemu_monitor.h, src/qemu/qemu_monitor.c: Add a new
  qemuMonitorSystemPowerdown() api call

15 years agoAdd API for 'stop' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 11:14:53 +0000 (12:14 +0100)]
Add API for 'stop' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add a new
  qemuMonitorStopCPUs() API
* src/qemu/qemu_driver.c: Replace direct monitor commands for 'stop'
  with qemuMonitorStopCPUs()

15 years agoRename qemudMonitorSendCont to qemuMonitorStartCPUs
Daniel P. Berrange [Wed, 23 Sep 2009 11:10:58 +0000 (12:10 +0100)]
Rename qemudMonitorSendCont to qemuMonitorStartCPUs

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Rename
  Rename qemudMonitorSendCont to qemuMonitorStartCPUs
* src/qemu/qemu_driver.c: Update callers for new name

15 years agoAdd API for 'change vnc password' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 11:06:57 +0000 (12:06 +0100)]
Add API for 'change vnc password' monitor command

* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add a
  new qemuMonitorSetVNCPassword() API
* src/qemu/qemu_driver.c: Refactor qemudInitPasswords to
  call qemuMonitorSetVNCPassword()

15 years agoAdd API for 'info cpus' monitor command
Daniel P. Berrange [Wed, 23 Sep 2009 10:49:14 +0000 (11:49 +0100)]
Add API for 'info cpus' monitor command

* src/qemu/qemu_monitor.h, src/qemu/qemu_monitor.c: Add a new
  qemuMonitorGetCPUInfo() command
* src/qemu/qemu_driver.c: Refactor qemudDetectVcpuPIDs to
  use qemuMonitorGetCPUInfo()

15 years agoPull QEMU monitor interaction out to separate file
Daniel P. Berrange [Tue, 22 Sep 2009 17:48:40 +0000 (18:48 +0100)]
Pull QEMU monitor interaction out to separate file

Pull out all the QEMU monitor interaction code to a separate
file. This will make life easier when we need to drop in a
new implementation for the forthcoming QMP machine friendly
monitor support.

Next step is to add formal APIs for each monitor command,
and remove direct commands for sending/receiving generic
data.

* src/Makefile.am: Add qemu_monitor.c to build
* src/qemu/qemu_driver.c: Remove code for monitor interaction
* src/qemu/qemu_monitor_text.c, src/qemu/qemu_monitor_text.h: New
  file for monitor interaction
* po/POTFILES.in: Add src/qemu/qemu_monitor_text.c

15 years agoMaintain value of ctxt->node in virInterfaceDefParseDhcp
Laine Stump [Tue, 29 Sep 2009 09:16:04 +0000 (11:16 +0200)]
Maintain value of ctxt->node in virInterfaceDefParseDhcp

* src/conf/interface_conf.c: This was causing subsequent calls to
  virXPathxxx() to fail, since ctxt->node was left pointing at the
  dhcp node, rather than the protocol node.

15 years agoFix some XPath relative node resets
Daniel Veillard [Tue, 29 Sep 2009 09:07:01 +0000 (11:07 +0200)]
Fix some XPath relative node resets

* src/util/xml.c: The virXPath... function take extra care to preserve
  the XPath context node (ctxt->node) but in the case of virXPathString
  and virXPathBoolean they forgot to do this on the error path. This
  patch fixes this and move all ctxt->node = relnode instuctions just
  after the xmlXPathEval() to make sure this doesn't happen if this code
  is modified.

15 years agoutil.h needs libvirt.h for virConnectPtr
Mark McLoughlin [Fri, 25 Sep 2009 13:20:12 +0000 (14:20 +0100)]
util.h needs libvirt.h for virConnectPtr

Seems standard to include internal.h in order to pull in libvirt.h

* src/util/util.h: include internal.h

15 years agoDon't require full daemon install for libvirt python bindings
Daniel P. Berrange [Mon, 28 Sep 2009 13:14:43 +0000 (14:14 +0100)]
Don't require full daemon install for libvirt python bindings

* libvirt.spec.in: libvirt-python only needs to depend on
  libvirt-clients

15 years agoFix API doc extractor to stop munging comment formatting
Daniel P. Berrange [Fri, 25 Sep 2009 12:24:40 +0000 (13:24 +0100)]
Fix API doc extractor to stop munging comment formatting

The python method help docs are copied across from the C
funtion comments, but in the process all line breaks and
indentation was being lost. This made the resulting text
and code examples completely unreadable. Both the API
doc extractor and the python generator were destroying
whitespace & this fixes them to preserve it exactly.

* docs/apibuild.py: Preserve all whitespace when extracting
  function comments. Print function comment inside a <![CDATA[
  section to fully preserve all whitespace. Look for the
  word 'returns' to describe return values, instead of 'return'
  to avoid getting confused with code examples including the
  C 'return' statement.
* python/generator.py: Preserve all whitespace when printing
  function help docs
* src/libvirt.c: Change any return parameter indicated by
  'return' to be 'returns', to avoid confusing the API extractor
* docs/libvirt-api.xml: Re-build for fixed descriptions

15 years agoFix cdub's surname spelling
Mark McLoughlin [Thu, 24 Sep 2009 13:50:51 +0000 (14:50 +0100)]
Fix cdub's surname spelling

15 years agoAdded Matthias Bolte as commiter
Daniel Veillard [Thu, 24 Sep 2009 13:32:16 +0000 (15:32 +0200)]
Added Matthias Bolte as commiter

15 years agoFix secret_driver compile warning, bug.
Charles Duffy [Thu, 24 Sep 2009 10:58:53 +0000 (12:58 +0200)]
Fix secret_driver compile warning, bug.

Set def to NULL in secretLoad(), otherwise we can access a
random pointer on error.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix unitialized variable in qemudDomainDetachHostPciDevice()
Charles Duffy [Thu, 24 Sep 2009 08:00:24 +0000 (09:00 +0100)]
Fix unitialized variable in qemudDomainDetachHostPciDevice()

* src/qemu/qemu_driver.c: initialize detach var

15 years agoFix a typo in virNetHasValidPciAddr() too
Mark McLoughlin [Thu, 24 Sep 2009 07:55:55 +0000 (08:55 +0100)]
Fix a typo in virNetHasValidPciAddr() too

* src/conf/domain_conf.h: check domain/bus/slot, not domain/domain/slot

15 years agoFix a typo in virDiskHasValidPciAddr()
Jiri Denemark [Wed, 23 Sep 2009 16:46:23 +0000 (18:46 +0200)]
Fix a typo in virDiskHasValidPciAddr()

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
15 years agoESX: Check if a datastore is accessible first
Matthias Bolte [Wed, 23 Sep 2009 13:08:25 +0000 (15:08 +0200)]
ESX: Check if a datastore is accessible first

An inaccessible datastore has no valid URL property so don't
access its URI property.

* src/esx/esx_vi.c: esxVI_LookupDatastoreByName(): check if datastore is
  accessible before accessing its URL property
* src/esx/esx_vmx.c: update to changed datastore properties

15 years agoESX remove phantom mode
Matthias Bolte [Wed, 23 Sep 2009 13:00:02 +0000 (15:00 +0200)]
ESX remove phantom mode

* src/esx/esx_driver.c: remove phantom mode

15 years agoESX replace esxUtil_EqualSuffix() with virFileHasSuffix()
Matthias Bolte [Wed, 23 Sep 2009 12:56:05 +0000 (14:56 +0200)]
ESX replace esxUtil_EqualSuffix() with virFileHasSuffix()

* src/esx/esx_util.[ch]: remove esxUtil_EqualSuffix()
* src/esx/esx_driver.c, src/esx/esx_vmx.c: replace esxUtil_EqualSuffix()
  with virFileHasSuffix()

15 years agoESX add esxDomainDefineXML()
Matthias Bolte [Wed, 23 Sep 2009 12:52:36 +0000 (14:52 +0200)]
ESX add esxDomainDefineXML()

A given domain XML gets converted to a VMX config, uploaded to the host
and registered as new virtual machine.

* src/esx/esx_driver.c: refactor datastore related path parsing into
  esxUtil_ParseDatastoreRelatedPath()
* src/esx/esx_util.[ch]: add esxUtil_ParseDatastoreRelatedPath()
* src/esx/esx_vi.[ch]: add esxVI_Context_UploadFile(), add datastores to
  the traversal in esxVI_BuildFullTraversalSpecList(), add
  esxVI_LookupDatastoreByName()
* src/esx/esx_vi_methods.[ch]: add esxVI_RegisterVM_Task()
* src/esx/esx_vi_types.c: make some error message more verbose
* src/esx/esx_vmx.[ch]: add esxVMX_AbsolutePathToDatastoreRelatedPath()
  to convert a path into a datastore related path, add esxVMX_ParseFileName()
  to convert from VMX path format to domain XML path format, extend the other
  parsing function to be datastore aware, add esxVMX_FormatFileName() to
  convert from domain XML path format to VMX path format, fix VMX ethernet
  entry formating
* tests/esxutilstest.c: add test for esxUtil_ParseDatastoreRelatedPath()
* tests/vmx2xmldata/*: update domain XML files to use datastore related paths
* tests/xml2vmxdata/*: update domain XML files to use datastore related paths,
  update VMX files to use absolute paths

15 years agoESX add esxVI_Occurence enum to for occurences
Matthias Bolte [Wed, 23 Sep 2009 12:40:41 +0000 (14:40 +0200)]
ESX add esxVI_Occurence enum to for occurences

Add esxVI_Occurence enum to describe expected occurence of items
* src/esx/esx_driver.c: update the use of esxVI_LookupVirtualMachineByUuid()
* src/esx/esx_vi.c: add an esxVI_Occurence parameter to
  esxVI_LookupVirtualMachineByUuid() and take care if esxVI_FindByUuid()
  can't find anything for a given uuid
* src/esx/esx_vi.h: add esxVI_Occurence enum
* src/esx/esx_vi_methods.c: expect null or more items to be returned
  from esxVI_FindByUuid()

15 years agoESX Whitespace cleanup
Matthias Bolte [Wed, 23 Sep 2009 12:37:26 +0000 (14:37 +0200)]
ESX Whitespace cleanup

15 years agoESX add x86_64 detection based on the CPUID
Matthias Bolte [Wed, 23 Sep 2009 12:29:39 +0000 (14:29 +0200)]
ESX add x86_64 detection based on the CPUID

* src/esx/esx_driver.c: add esxSupportsLongMode() and update esxCapsInit()
* src/esx/esx_vi.[ch]: Add AnyType handling for lists
* src/esx/esx_vi_types.c: bind VI type HostCpuIdInfo

15 years agoESX add tests for the VMX to/from domain XML mapping
Matthias Bolte [Wed, 23 Sep 2009 12:25:52 +0000 (14:25 +0200)]
ESX add tests for the VMX to/from domain XML mapping

* tests/.gitignore: ignore new test binaries
* tests/Makefile.am: add new tests
* tests/esxutilstest.c: test esxVMX_IndexToDiskName()
* tests/vmx2xmldata/*: config files for the VMX to domain XML test
* tests/vmx2xmltest.c: test the VMX to domain XML mapping
* tests/xml2vmxdata/*: config files for the domain XML to VMX test
* tests/xml2vmxtest.c: test the domain XML to VMX mapping

15 years agoESX Add esxDomainXMLToNative()
Matthias Bolte [Wed, 23 Sep 2009 12:16:41 +0000 (14:16 +0200)]
ESX Add esxDomainXMLToNative()

Extend and cleanup the VMX to domain XML mapping. Add the domain XML to
VMX mapping functions.

* src/esx/esx_driver.c: add esxDomainXMLToNative()
* src/esx/esx_vmx.[ch]: add esxVMX_SCSIDiskNameToControllerAndID(),
  esxVMX_IDEDiskNameToControllerAndID(), esxVMX_FloppyDiskNameToController(),
  esxVMX_GatherSCSIControllers(), add basic handling for the VMX guestOS entry
  to distinguish between i686 and x86_64, make SCSI virtualDev VMX entry
  optional as it should be, map the VMX networkName entry to the domain XML
  interface bridge name, add basic mapping for serial devices in pipe mode,
  add several esxVMX_Format*() functions

15 years agoESX Set challenge for auth callback to hostname
Matthias Bolte [Wed, 23 Sep 2009 12:11:54 +0000 (14:11 +0200)]
ESX Set challenge for auth callback to hostname

This enables the auth callback to automatically distinguish between
requests for ESX host and vCenter credentials.

* src/esx/esx_util.[ch]: set challenge for auth callback to hostname

15 years agoESX Add esxNodeGetFreeMemory()
Matthias Bolte [Wed, 23 Sep 2009 12:09:44 +0000 (14:09 +0200)]
ESX Add esxNodeGetFreeMemory()

* src/esx/esx_driver.c: add esxNodeGetFreeMemory(), cache IP address
* src/esx/esx_vi.[ch]: refactor resource pool query into esxVI_GetResourcePool()
* src/esx/esx_vi_types.[ch]: bind VI type ResourcePoolResourceUsage

15 years agoFix up "make syntax-check" after the tree restructuring.
Chris Lalancette [Wed, 23 Sep 2009 12:58:13 +0000 (14:58 +0200)]
Fix up "make syntax-check" after the tree restructuring.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agonetwork: add 'bootp' and 'tftp' config
Paolo Bonzini [Mon, 21 Sep 2009 20:50:25 +0000 (22:50 +0200)]
network: add 'bootp' and 'tftp' config

Currently, libvirtd will start a dnsmasq process for the virtual
network, but (aside from killing the dnsmasq process and replacing it),
there's no way to define tftp boot options.

This change introduces the appropriate tags to the dhcp configuration:

 <network>
   <name>default</name>
   <bridge name="virbr%d" />
   <forward/>
   <ip address="192.168.122.1" netmask="255.255.255.0">
     <tftp root="/var/lib/tftproot" />
     <dhcp>
       <range start="192.168.122.2" end="192.168.122.254" />
       <bootp file="pxeboot.img"/>
     </dhcp>
   </ip>
 </network>

When the attributes are present, these are passed to the
arguments to dnsmasq:

 dnsmasq [...] --enable-tftp --tftp-root /srv/tftp --dhcp-boot pxeboot.img
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^
                      from <tftp />                     from <bootp />

At present, only local tftp servers are supported (ie, dnsmasq runs as
the tftp server), but we could improve this in future by adding a
server= attribute.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2009-09-21  Paolo Bonzini  <pbonzini@redhat.com>
            Jeremy Kerr  <jk@ozlabs.org>

* docs/formatnetwork.html.in: Document new tags.
* docs/formatnetwork.html: Regenerate.
* docs/schemas/network.rng: Update.
* src/network_conf.c (virNetworkDefFree): Free new fields.
(virNetworkDHCPRangeDefParseXML): Parse <bootp>.
(virNetworkIPParseXML): New, parsing <dhcp> and <tftp>.
(virNetworkDefParseXML): Use virNetworkIPParseXML instead of
virNetworkDHCPRangeDefParseXML.
(virNetworkDefFormat): Pretty print new fields.
* src/network_conf.h (struct _virNetworkDef): Add netboot fields.
* src/network_driver.c (networkBuildDnsmasqArgv): Add
TFTP and BOOTP arguments.

* tests/Makefile.am (EXTRA_DIST): Add networkschemadata.
* tests/networkschematest: Look in networkschemadata.
* tests/networkschemadata/netboot-network.xml: New.

15 years agoIntroduce virStrncpy.
Chris Lalancette [Mon, 3 Aug 2009 12:37:44 +0000 (14:37 +0200)]
Introduce virStrncpy.

Add the virStrncpy function, which takes a dst string, source string,
the number of bytes to copy and the number of bytes available in the
dest string.  If the source string is too large to fit into the
destination string, including the \0 byte, then no data is copied and
the function returns NULL.  Otherwise, this function copies n bytes
from source into dst, including the \0, and returns a pointer to the
dst string.  This function is intended to replace all unsafe uses
of strncpy in the code base, since strncpy does *not* guarantee that
the buffer terminates with a \0.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix handling of Xen(ner) detection
Daniel P. Berrange [Tue, 25 Aug 2009 13:17:29 +0000 (14:17 +0100)]
Fix handling of Xen(ner) detection

Latest upstream QEMU can be built with Xen support, which introduces
a -xen-domid argument. This was  mistakenly detected as -domid due
to old Xenner support. Adapt to cope with both syntax. Also only
set domid if the virt type is xen, or the guest type is xen

* src/qemu_conf.c, src/qemu_conf.h: Detect new -xen-domid flag in
  preference to -domid.
* tests/qemuxml2argvdata/qemuxml2argv-bootloader.args,
  tests/qemuxml2argvdata/qemuxml2argv-input-xen.args: Add missing
  -domid param
* tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args: Remove bogus
  -boot param.
* tests/qemuxml2argvtest.c: Add missing QEMUD_CMD_FLAG_DOMID params

15 years agoIgnore auto-generated header file
Daniel P. Berrange [Tue, 22 Sep 2009 15:12:51 +0000 (16:12 +0100)]
Ignore auto-generated header file

* include/libvirt/.gitignore: Ignore libvirt.h

15 years agoFix xen driver refcounting.
Matthias Bolte [Tue, 22 Sep 2009 13:12:48 +0000 (15:12 +0200)]
Fix xen driver refcounting.

The commit cb51aa48a777ddae6997faa9f28350cb62655ffd "Fix up connection
reference counting." changed the driver closing and virConnectPtr
unref-logic in virConnectClose().

Before this commit virConnectClose() closed all drivers of the given
virConnectPtr and virUnrefConnect()'ed it afterwards. After this
commit the driver-closing is done in virUnrefConnect() if and only if
the ref-count of the virConnectPtr dropped to zero.

This change in execution order leads to a virConnectPtr leak, at least
for connections to Xen.

The relevant call sequences:

virConnectOpen() -> xenUnifiedOpen() ...

... xenInotifyOpen() -> virConnectRef(conn)

... xenStoreOpen() -> xenStoreAddWatch() -> conn->refs++

virConnectClose() -> xenUnifiedClose() ...

... xenInotifyClose() -> virUnrefConnect(conn)

... xenStoreClose() -> xenStoreRemoveWatch() -> virUnrefConnect(conn)

Before the commit this additional virConnectRef/virUnrefConnect calls
where no problem, because virConnectClose() closed the drivers
explicitly and the additional refs added by the Xen subdrivers were
removed properly. After the commit this additional refs result in a
virConnectPtr leak (including a leak of the hypercall file handle;
that's how I noticed this problem), because now the drivers are only
close if and only if the ref-count drops to zero, but this cannot
happen anymore, because the additional refs from the Xen subdrivers
would only be removed if the drivers get closed, but that doesn't
happen because the ref-count cannot drop to zero.

The fix for this problem is simple: remove the
virConnectRef/virUnrefConnect calls from the Xen subdrivers (see
attached patch). Maybe someone could explain why the Xen Inotify and
Xen Store driver do this extra ref-counting, but none of the other Xen
subdrivers. It seems unnecessary to me and can be removed without
problems.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix a number of small typos
Dan Kenigsberg [Tue, 22 Sep 2009 10:54:57 +0000 (12:54 +0200)]
Fix a number of small typos

15 years agolxc: suspend/resume support
Ryota Ozaki [Mon, 21 Sep 2009 14:31:22 +0000 (23:31 +0900)]
lxc: suspend/resume support

* src/conf/domain_conf.c: Don't assume all virDomainObjPtr have
  a non-NULL monitor_chr field in virDomainObjFormat.
* src/lxc/lxc_driver.c: Implement suspend/resume driver APis
* src/util/cgroup.c, src/util/cgroup.h: Support the 'freezer'
  cgroup controller
* src/libvirt_private.syms: Export virCgroupSetFreezerState
  and virCgroupGetFreezerState

15 years agoOpenVZ Fix a restriction about domain names
Yuji NISHIDA [Tue, 22 Sep 2009 10:19:09 +0000 (12:19 +0200)]
OpenVZ Fix a restriction about domain names

* src/openvz/openvz_driver.c: try to autogenerate a non-conflicting
  id for the domain and use the name field as the name not as id.

15 years agoadd doc for graphic and video elements
Florian Vichot [Tue, 22 Sep 2009 08:32:14 +0000 (10:32 +0200)]
add doc for graphic and video elements

* docs/formatdomain.html.in: explain the new syntax of the video and
  graphic elements in the domain XML

15 years agoprevent attempt to call cat -c during virDomainSave to raw
Charles Duffy [Tue, 22 Sep 2009 06:56:39 +0000 (08:56 +0200)]
prevent attempt to call cat -c during virDomainSave to raw

This was prevent virDomainSave from working properly by default,
which is a bad thing.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix up 'neccessary -> necessary' in a comment.
Chris Lalancette [Mon, 21 Sep 2009 09:44:54 +0000 (11:44 +0200)]
Fix up 'neccessary -> necessary' in a comment.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoDon't do virSetConnError when virDrvSupportsFeature is successful.
Chris Lalancette [Mon, 21 Sep 2009 09:43:23 +0000 (11:43 +0200)]
Don't do virSetConnError when virDrvSupportsFeature is successful.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix a double-free in qemudRunLoop()
Chris Lalancette [Mon, 21 Sep 2009 09:42:32 +0000 (11:42 +0200)]
Fix a double-free in qemudRunLoop()

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoFix up comments for domainXML{To,From}Native.
Chris Lalancette [Sun, 6 Sep 2009 14:03:06 +0000 (16:03 +0200)]
Fix up comments for domainXML{To,From}Native.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoSimple fix of a comment in qemuStringToArgvEnv.
Chris Lalancette [Sun, 6 Sep 2009 13:55:49 +0000 (15:55 +0200)]
Simple fix of a comment in qemuStringToArgvEnv.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoRemove an unnecessary variable from remoteIOReadMessage().
Chris Lalancette [Mon, 21 Sep 2009 09:51:42 +0000 (11:51 +0200)]
Remove an unnecessary variable from remoteIOReadMessage().

Signed-off-by: Chris Lalancette <clalance@redhat.com>
15 years agoRemove auto-generated header file from repo
Daniel P. Berrange [Mon, 21 Sep 2009 14:44:06 +0000 (15:44 +0100)]
Remove auto-generated header file from repo

* include/libvirt/libvirt.h: Delete auto-generated file

15 years agoTweak specfile to fix RHEL6 rules & ESX/PHYP enablement
Daniel P. Berrange [Wed, 16 Sep 2009 15:02:38 +0000 (16:02 +0100)]
Tweak specfile to fix RHEL6 rules & ESX/PHYP enablement

* libvirt.spec.in: ESX/PHYP drivers do not require libvirtd.
  RHEL-6 should include LXC on all arches

15 years agoMove example XML files into examples/xml
Daniel P. Berrange [Wed, 16 Sep 2009 18:02:59 +0000 (19:02 +0100)]
Move example XML files into examples/xml

* docs/storage/: Move to examples/xml/storage/
* docs/test*.xml: Move to examples/xml/test/
* docs/Makefile.am: Remove example XML files from dist
* Makefile.am: Add examples/xml to EXTRA_DIST
* tests/virshtest.c: Update for moved test XML
* libvirt.spec.in: Include example XML files as docs
* tests/int-overflow: UPdate for moved XML

15 years agoRemove all generated docs from source control
Daniel P. Berrange [Wed, 16 Sep 2009 17:56:56 +0000 (18:56 +0100)]
Remove all generated docs from source control

* docs/*.html, docs/devhelp/*.html, docs/html/*.html: Delete
* docs/.gitignore, docs/devhelp/.gitignore, docs/html/.gitignore:
  Ignore generated docs files
* docs/Makefile.am: Rebuild all HTML docs for 'all' target
  and include them in EXTRA_DIST and CLEANFILES
* docs/devhelp/Makefile.am: Include HTML in CLEANFILES

15 years agoFix missing data file in qemuhelpdata
Daniel P. Berrange [Wed, 16 Sep 2009 17:17:20 +0000 (18:17 +0100)]
Fix missing data file in qemuhelpdata

* tests/Makefile.am: Add missing data file to extra dist

15 years agoMisc syntax-check fixes
Daniel P. Berrange [Wed, 16 Sep 2009 16:26:27 +0000 (17:26 +0100)]
Misc syntax-check fixes

15 years agoMove remote protocol definition into src/remote/
Daniel P. Berrange [Wed, 16 Sep 2009 15:55:16 +0000 (16:55 +0100)]
Move remote protocol definition into src/remote/

When making changes to the remote protocol, src/ is always built
first, so rpcgen should live there, to avoid having to run make
in the 'daemon/' directory before building src/

* src/Makefile.am: Add rules for rpcgen, and drop -I../daemon from
  remote client build
* daemon/Makefile.am: Add -I../src/remote/ to libvirtd build
  and remove rpcgen rules
* daemon/libvirtd.c: Adapt include of remote_driver.h taking
  into account new -I flag
* daemon/remote_protocol.c, daemon/remote_protocol.h,
  daemon/remote_protocol.x: Move to src/remote/
* daemon/rpcgen_fix.pl: Move to src/remote/rpcgen_fix.pl

15 years agoAdd a README file to src/ explaining the directory structure
Daniel P. Berrange [Wed, 16 Sep 2009 15:42:24 +0000 (16:42 +0100)]
Add a README file to src/ explaining the directory structure

* src/README: New file

15 years agoMove all shared utility files to src/util/
Daniel P. Berrange [Wed, 16 Sep 2009 15:28:46 +0000 (16:28 +0100)]
Move all shared utility files to src/util/

* src/bridge.c, src/bridge.h, src/buf.c, src/buf.h, src/cgroup.c,
  src/cgroup.h, src/conf.c, src/conf.h, src/event.c, src/event.h,
  src/hash.c, src/hash.h, src/hostusb.c, src/hostusb.h,
  src/iptables.c, src/iptables.h, src/logging.c, src/logging.h,
  src/memory.c, src/memory.h, src/pci.c, src/pci.h, src/qparams.c,
  src/qparams.h, src/stats_linux.c, src/stats_linux.h,
  src/threads-pthread.c, src/threads-pthread.h, src/threads-win32.c,
  src/threads-win32.h, src/threads.c, src/threads.h, src/util.c,
  src/util.h, src/uuid.c, src/uuid.h, src/virterror.c,
  src/virterror_internal.h, src/xml.c, src/xml.h: Move all files
  into src/util/
* daemon/Makefile.am: Add -Isrc/util/ to build flags
* src/Makefile.am: Add -Isrc/util/ to build flags and update for
  moved files
* src/libvirt_private.syms: Export cgroup APIs since they're now
  in util rather than linking directly to drivers
* src/xen/xs_internal.c: Disable bogus virEventRemoveHandle call
  when built under PROXY
* proxy/Makefile.am: Update for changed file locations. Remove
  bogus build of event.c
* tools/Makefile.am, tests/Makefile.am: Add -Isrc/util/ to build flags

15 years agoMove all XML configuration handling to src/conf/
Daniel P. Berrange [Wed, 16 Sep 2009 14:39:12 +0000 (15:39 +0100)]
Move all XML configuration handling to src/conf/

* src/capabilities.c, src/capabilities.h, src/domain_conf.c,
  src/domain_conf.h, src/domain_event.c, src/domain_event.h,
  src/interface_conf.c, src/interface_conf.h,
  src/network_conf.c, src/network_conf.h, src/node_device_conf.c,
  src/node_device_conf.h, src/secret_conf.c, src/secret_conf.h,
  src/storage_conf.c, src/storage_conf.h, src/storage_encryption_conf.c,
  src/storage_encryption_conf.h: Move to src/conf/
* src/Makefile.am: Add -Isrc/conf to the individual build targets
  which need to use XML config APIs. Remove LIBXML_CFLAGS, LIBSSH2_CFLAGS
  and SELINUX_CFLAGS from global INCLUDES and only have them in build
  targets which actually need them.  Create a libvirt_conf.la
  convenience library for all config parsers
* src/hostusb.h: Remove bogus include of domain_conf.h
* tests/Makefile.am: Add -Isrc/conf. Remove bogus -I$builddir/src
  since it never has any generated header files
* daemon/Makefile.am: Add -Isrc/conf
* proxy/Makefile.am: Add -Isrc/conf and cope with renamed files
* src/hash.c: Remove bogus include of libxml/threads.h

15 years agoMake pki_check.sh into an installed & supported tool
Daniel P. Berrange [Wed, 16 Sep 2009 13:42:57 +0000 (14:42 +0100)]
Make pki_check.sh into an installed & supported tool

* docs/pki_check.sh: Move to tool/virt-pki-validate.in and add
  in POD man page documentation
* tools/.gitignore: Ignore generated virt-pki-validate file
* tools/Makefile.am: Install & build virt-pki-validate and
  virt-pki-validate.1
* docs/remote.html, docs/remote.html.in: Refer to new tool
  name virt-pki-validate
* libvirt.spec.in, mingw32-libvirt.spec.in: Add virt-pki-validate
  and virt-pki-validate.1 to files list

15 years agoRe-arrange python generator to make it clear what's auto-generated
Daniel P. Berrange [Wed, 16 Sep 2009 13:03:53 +0000 (14:03 +0100)]
Re-arrange python generator to make it clear what's auto-generated

* README: New file describing what each file is used for
* livvirt-override.c, libvirt-override.py, libvirt-override-api.xml,
  libvirt-override-virConnect.py: Manually written code overriding
  the generator
* typewrappers.c, typewrappers.h: Data type wrappers
* generator.py: Automatically pre-prend contents of libvirt-override.py
  to generated libvirt.py. Output into libvirt.py directly instead of
  libvirtclass.py. Don't generate libvirtclass.txt at all. Write C
  files into libvirt.c/.h directly
* Makefile.am: Remove rule for creating libvirt.py from libvirt-override.py
  and libvirtclass.py, since generator.py does it directly

15 years agoRemove obsolete files
Daniel P. Berrange [Wed, 16 Sep 2009 12:15:48 +0000 (13:15 +0100)]
Remove obsolete files

* docs/Goals, RENAMES, mylibtool: Removed

15 years agoMove docs/examples into examples/
Daniel P. Berrange [Wed, 16 Sep 2009 12:07:48 +0000 (13:07 +0100)]
Move docs/examples into examples/

* Makefile.am: Add examples/dominfo examples/domsuspend examples/python
  as SUBDIRS
* configure.in: Update AC_OUTPUT for new/old Makefiles
* docs/Makefile.am: Remove examples from SUBDIRS
* docs/examples/info1.c: Move to examples/dominfo/info1.c
* docs/examples/suspend.c: Move to examples/domsuspend/suspend.c
* docs/examples: Remove all remaining files
* docs/examples/python: Moved to examples/python/
* examples/dominfo/Makefile.am, examples/domsuspend/Makefile.am: New
  build files
* libvirt.spec.in: Update to take account of moved examples

15 years agoRemove unused images from docs/ directory
Daniel P. Berrange [Wed, 16 Sep 2009 11:43:17 +0000 (12:43 +0100)]
Remove unused images from docs/ directory

* 16favicon.png, Libxml2-Logo-90x34.gif, libvirHeader.png,
  libvirLogo.png, windows-cygwin-1.png, windows-cygwin-2.png,
  windows-cygwin-3.png: Remove unreferenced files
* Makefile.am: Remove deleted files from EXTRA_DIST

15 years agoRename daemon main code
Daniel P. Berrange [Wed, 16 Sep 2009 11:37:26 +0000 (12:37 +0100)]
Rename daemon main code

* daemon/qemud.c: Rename to daemon/libvirtd.c
* daemon/qemud.h: Rename to daemon/libvirtd.h
* daemon/Makefile.am, daemon/dispatch.h, daemon/mdns.c,
  daemon/remote.h: Update for renamed libvirtd.h file

15 years agoMove config files to align with driver sources
Daniel P. Berrange [Wed, 16 Sep 2009 11:31:13 +0000 (12:31 +0100)]
Move config files to align with driver sources

* daemon/default-network.xml: Move to src/network/default.xml
* daemon/libvirtd_qemu.aug, daemon/test_libvirtd_qemu.aug: Move
  to src/qemu/
* src/qemu.conf: Move to src/qemu/qemu.conf
* daemon/Makefile.am: Remove rules for default-nmetwork.xml and
  libvirtd_qemu.aug and test_libvirtd_qemu.aug. Fix typo in
  uninstall-local that would install polkit again.
* src/Makefile.am: Add rules for installing network/default.xml
  and the qemu/*.aug files. Add test case for QEMU augeas files.
  Add uninstall-local rule for files/directories created during
  install. Rename install-exec-local to install-data-local.
  Only install qemu.conf if WITH_QEMU is set.
* tests/networkschematest: Update for XML location move

15 years agoMove virsh into tools/ directory
Daniel P. Berrange [Wed, 16 Sep 2009 11:01:53 +0000 (12:01 +0100)]
Move virsh into tools/ directory

Move the virsh tool and its man page into the tools directory

* Makefile.am: Remove rules for virsh.1 man page
* virsh.1: Remove auto-generated file
* docs/Makefile.am: Remove rules for virsh.pod man page
* docs/virsh.pod: Move to tools/ directory
* src/Makefile.am, src/.gitignore: Remove rules for virsh
* src/console.c, src/console.h, src/*.ico, src/virsh_win_icon.rc,
  src/virsh.c: Move into tools/ directory
* tools/Makefile.am: Add rules for building virsh
* tools/.gitignore: Ignore virsh built files
* tests/virshtest.c, tests/int-overflow: Update for new
  virsh location

15 years agoMove security drivers to src/security/
Daniel P. Berrange [Tue, 15 Sep 2009 18:06:37 +0000 (19:06 +0100)]
Move security drivers to src/security/

* src/Makefile.am, src/qemu/qemu_conf.h, src/qemu/qemu_driver.c,
  tests/seclabeltest.c: Adapt for changed paths
* src/security.c: Rename to src/security/security_driver.c
* src/security.h: Rename to src/security/security_driver.h
* src/security_selinux.c, src/security_selinux.h: Move to src/security/

15 years agoMove secret driver into src/secret/
Daniel P. Berrange [Tue, 15 Sep 2009 17:59:58 +0000 (18:59 +0100)]
Move secret driver into src/secret/

* daemon/qemud.c, src/Makefile.am: Adapt for changed paths
* src/secret_driver.c, src/secret_driver.h: Move to src/secret/

15 years agoMove netcf interface driver into src/interface/
Daniel P. Berrange [Tue, 15 Sep 2009 17:55:16 +0000 (18:55 +0100)]
Move netcf interface driver into src/interface/

* daemon/qemud.c, src/Makefile.am: Adapt for changed paths
* src/interface_driver.c: Rename to src/interface/netcf_driver.c
* src/interface_driver.h: Rename to src/interface/netcf_driver.h

15 years agoMove network driver into src/network
Daniel P. Berrange [Tue, 15 Sep 2009 17:52:58 +0000 (18:52 +0100)]
Move network driver into src/network

* daemon/qemud.c, src/Makefile.am: Adapt for changed paths
* src/network_driver.c: Rename to src/network/bridge_driver.c
* src/network_driver.h: Rename to src/network/bridge_driver.h

15 years agoMove remote driver to src/remote/
Daniel P. Berrange [Tue, 15 Sep 2009 17:47:05 +0000 (18:47 +0100)]
Move remote driver to src/remote/

* daemon/mdns.c: Remove bogus include
* daemon/qemud.c, src/Makefile.am, src/libvirt.c: Adapt for
  changed paths
* src/remote_internal.c: Rename to src/remote/remote_driver.c
* src/remote_internal.h: Rename to src/remote/remote_driver.h

15 years agoMove test driver into src/test/
Daniel P. Berrange [Tue, 15 Sep 2009 17:38:50 +0000 (18:38 +0100)]
Move test driver into src/test/

* src/Makefile.am, src/libvirt.c: Adjust for changed paths
* src/test.c: Rename to src/test/test_driver.c,
* src/test.h: Rename to src/test/test_driver.h

15 years agoMove node device drivers to src/node_device/
Daniel P. Berrange [Tue, 15 Sep 2009 17:30:17 +0000 (18:30 +0100)]
Move node device drivers to src/node_device/

* daemon/qemud.c, src/Makefile.am: Update for changed paths
* src/node_device*.{h,c}: Move to src/node_device/
* src/storage/storage_backend.c: Remove bogus import of node_device.c

15 years agoMove storage drivers into src/storage/
Daniel P. Berrange [Tue, 15 Sep 2009 16:55:05 +0000 (17:55 +0100)]
Move storage drivers into src/storage/

* daemon/qemud.c, src/Makefile.am: Adapt for changed paths
* src/storage*.c, src/storage/*.h, src/parthelpre.c: Move
  to src/storage/

15 years agoMove OpenVZ driver to src/openvz/
Daniel P. Berrange [Tue, 15 Sep 2009 16:32:56 +0000 (17:32 +0100)]
Move OpenVZ driver to src/openvz/

* src/openvz_conf.c, src/openvz_conf.h, src/openvz_driver.c,
  src/openvz_driver.h: Move to src/openvz/
* src/Makefile.am, src/libvirt.c: Adjust for changed paths

15 years agoMove UML driver to src/uml/
Daniel P. Berrange [Tue, 15 Sep 2009 16:25:30 +0000 (17:25 +0100)]
Move UML driver to src/uml/

* src/uml_conf.c, src/uml_conf.h, src/uml_driver.c,
  src/uml_driver.h: Move to src/uml/
* daemon/qemud.c, src/Makefile.am: Adjust for changed paths

15 years agoMove QEMU driver to src/qemu/
Daniel P. Berrange [Tue, 15 Sep 2009 16:14:43 +0000 (17:14 +0100)]
Move QEMU driver to src/qemu/

* src/qemu_conf.c, src/qemu_conf.h, src/qemu_driver.c,
  src/qemu_driver.h: Move to src/qemu/
* daemon/qemud.c, src/Makefile.am, tests/qemuargv2xmltest.c,
  tests/qemuhelptest.c, tests/qemuxml2argvtest.c,
  tests/qemuxml2xmltest.c: Adapt for changed paths

15 years agoMove LXC driver into src/lxc/
Daniel P. Berrange [Tue, 15 Sep 2009 16:03:01 +0000 (17:03 +0100)]
Move LXC driver into src/lxc/

* src/lxc_conf.c, src/lxc_conf.h, src/lxc_container.c,
  src/lxc_container.h, src/lxc_controller.c, src/lxc_driver.c,
  src/lxc_driver.h, src/veth.c, src/veth.h: Move to src/lxc/
* src/opennebula/one_driver.c: Remove bogus veth.h include
* src/Makefile.am: Adjust for lxc paths
* daemon/qemud.c: Adjust include for lxc

15 years agoMove xen driver code into src/xen/ directory
Daniel P. Berrange [Tue, 15 Sep 2009 15:38:33 +0000 (16:38 +0100)]
Move xen driver code into src/xen/ directory

* src/Makefile.am, src/proxy_internal.c, src/proxy_internal.h
  src/sexpr.c, src/sexpr.h, src/xen_unified.c, src/xen_unified.h,
  src/xen_internal.c, src/xen_internal.h, src/xen_inotify.c,
  src/xen_inotify.h, src/xend_internal.c, src/xend_internal.h,
  src/xm_internal.c, src/xm_internal.h, src/xs_internal.c,
  src/xs_internal.h: Move to src/xen/ directory
* proxy/Makefile.am, proxy/libvirt_proxy.c, src/Makefile.am,
  src/libvirt.c, tests/sexpr2xmltest.c, tests/statstest.c,
  tests/xencapstest.c, tests/xmconfigtest.c, tests/xml2sexprtest.c:
  Adapt to changed xen location
* src/stats_linux.h, src/stats_linux.c: Remove xen specific block
  stats APIs
* src/qemu_driver.c, src/uml_driver.c: Add missing sys/un.h include
  uncovered after change to stats_linux.h
* src/xen/block_stats.h, src/xen/block_stats.c: Add xen specific
  block stats APIs

15 years agoRename qemud/ directory to daemon/
Daniel P. Berrange [Tue, 15 Sep 2009 14:49:29 +0000 (15:49 +0100)]
Rename qemud/ directory to daemon/

* qemud/: Rename to daemon/
* Makefile.am, configure.in, src/Makefile.am, src/remote_internal.c,
  tests/Makefile.am, tests/eventtest.c: s/qemud/daemon/ where needed

15 years agoRefactor libvirt.spec to allow client-only builds
Daniel P. Berrange [Wed, 16 Sep 2009 15:02:38 +0000 (16:02 +0100)]
Refactor libvirt.spec to allow client-only builds

Some architectures in certain RHEL versions do not include any
hypervisors. Update the specfile to allow those to easily build
a remote client only version of libvirt. ie no libvirtd related
bits at all.

* qemud/Makefile.am: Always instal SASL config since its needed
  by client too
* libvirt.spec.in: Re-factor specfile conditionals to allow entire
  server side build to be disabled easily, eg a remote client only
  build. Make RHEL-5 do client only build for s390/ppc. Make RHEL-6
  do a client only build for all non-x86_64 archs. Enable LXC on
  RHEL-6. Enable all Fedora >= 6 features on RHEL-6 too. Add some
  more conditionals around dnsmasq/iptables/hal Requires tags.
  Add missing e2fsprogs-devel BR for RHEL-5 as workaround for broken
  parted. Fix the device mapper BR for RHEL-5. Add conditional rules
  for ESX build. Add conditional rules for SELinux + HAL builds.
  Fix a mistaken %{with_qemu} to be %{with_network} when setting
  up default network XML

15 years agoFix leak in PCI hostdev hot-unplug
Mark McLoughlin [Thu, 17 Sep 2009 14:32:45 +0000 (15:32 +0100)]
Fix leak in PCI hostdev hot-unplug

* src/qemu_driver.c: sync the hostdev hot-unplug code with the disk/net
  code.

15 years agoFix net/disk hot-unplug segfault
Mark McLoughlin [Thu, 17 Sep 2009 14:31:08 +0000 (15:31 +0100)]
Fix net/disk hot-unplug segfault

When we hot-unplug the last device, we're currently double-freeing
the device definition.

Reported by Martin Banas here:

  https://bugzilla.redhat.com/523953

* src/qemu_driver.c: fix double free

15 years agoESX add support for vmxnet3 virtual device
Shahar Klein [Wed, 16 Sep 2009 10:04:49 +0000 (12:04 +0200)]
ESX add support for vmxnet3 virtual device

* src/esx/esx_vmx.c: add it to the list of accepted devices when
  parsing the Ethernet section.

15 years agodoc: don't emit trailing blanks into generated and VC'd NEWS file
Jim Meyering [Tue, 15 Sep 2009 13:01:26 +0000 (15:01 +0200)]
doc: don't emit trailing blanks into generated and VC'd NEWS file

* docs/Makefile.am ($(top_builddir)/NEWS): Filter out trailing
white space.

15 years agoMore whitespace problems
Daniel Veillard [Tue, 15 Sep 2009 12:31:59 +0000 (14:31 +0200)]
More whitespace problems

15 years agoFix some last minute whitespace problems.
Daniel Veillard [Tue, 15 Sep 2009 12:30:55 +0000 (14:30 +0200)]
Fix some last minute whitespace problems.

15 years agoRelease of libvirt 0.7.1
Daniel Veillard [Tue, 15 Sep 2009 12:24:51 +0000 (14:24 +0200)]
Release of libvirt 0.7.1

* configure.in docs/news.html.in libvirt.spec.in src/libvirt_public.syms:
  updates to new release
* NEWS docs/devhelp/libvirt-libvirt.html docs/html/libvirt-libvirt.html
  docs/libvirt-api.xml docs/libvirt-refs.xml docs/news.html
  include/libvirt/libvirt.h: regenerated

15 years agoUpdate a number of localizations and regenerate
Daniel Veillard [Tue, 15 Sep 2009 11:59:13 +0000 (13:59 +0200)]
Update a number of localizations and regenerate

* as.po bn_IN.po de.po gu.po hi.po kn.po ko.po ml.po mr.po or.po pa.po
  pl.po ta.po te.po zh_CN.po got updated

15 years agoFix dlopen of secrets driver
Daniel P. Berrange [Tue, 15 Sep 2009 10:11:10 +0000 (11:11 +0100)]
Fix dlopen of secrets driver

* src/Makefile.am: Add gnulib.la for base64 functions
* src/libvirt_private.syms: Export virFileNameMatchesSuffix

15 years agoAdd UUID definition required by storage encryption import
Daniel P. Berrange [Mon, 14 Sep 2009 20:09:07 +0000 (21:09 +0100)]
Add UUID definition required by storage encryption import

* docs/schemas/storagevol.rng: storage encryption rules require
  that UUID type be defined