Add extra state to frontend transition to allow reset to cleanup
requests after CLOSED transition but before disconnecting granter

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Cleanup PreparedReqs before closing the ring

To unprepare reqs, the granter is required, which can only operate
when the frontend is connected.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Force calling BlockRingPoll as DPC may not run.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #33 from OwenSmith/coinstaller-disk-timeout

Coinstaller disk timeout

Fix service key name

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Increase disk timeout during co-installer to a minimum of 120 seconds
to match timeout in backend(s)

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #32 from OwenSmith/pdoreset

Prevent an assertion by triggering the DPC to poll frontend during pause...

Prevent an assertion by triggering the DPC to poll frontend during pause.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #31 from OwenSmith/increase-timeout

Increase PdoReset timeout and logging.

Increase PdoReset timeout and logging.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #29 from OwenSmith/fix-reset

Check for right flag in granter

Check for right flag in granter

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #28 from OwenSmith/fix-reset

Fix PdoReset by attempting to poll ring for up to 5 minutes before bugch...

Fix PdoReset by attempting to poll ring for up to 5 minutes before bugchecking

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #27 from OwenSmith/master

SDV is picky about %d/%u printf format specifiers

SDV is picky about %d/%u printf format specifiers

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #26 from pauldu/gnttab

Use new GNTTAB interface

Use new GNTTAB interface

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge pull request #25 from OwenSmith/reduce-peak-grants

Reduce peak grants

Fix checked-only bugcheck (0xD1 due to IsOnList in buffer.c)

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Submit all prepared requests then attempt to prepare the next SRB

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Fold BlockRingPush into BlockRingSubmit

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Move Lookaside functions to same part of pdo.c

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Always bounce SRBs via FreshSrbs queue

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Refactor: internalize request preparation functions into a single call

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Track current/maximum grant usage

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #24 from OwenSmith/sdv

Fix SDV on xencrsh

Fix SDV on xencrsh

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #23 from OwenSmith/sdv

Fix build by removing (redefinition) of MmGetPhysicalAddress

Fix build by removing (redefinition) of MmGetPhysicalAddress

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #22 from OwenSmith/sdv

Add Sdv to build.py

Fix SDV errors, completes SDV and DVL log run
Notes: Date format must be US (MM/DD/YY) for WHQL tests

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add sdv build to build.py, include nosdv option to not run sdv

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #21 from OwenSmith/master

Log BLKIF_OP_* values when backend fails request

Log BLKIF_OP_* values when backend fails request
Dont attempt to interpret as SCSIOP_* values

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #20 from OwenSmith/master

[CA-134598] Store the (partial) tag along with the XENVBD_REQUEST.

[CA-134598] Store the (partial) tag along with the XENVBD_REQUEST.
Migrate and a bus/target reset will re-queue any existing requests, but not
reset the request tagging correctly, and will eventually run out of free tags.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #19 from pauldu/waitblock

Fix BSOD caused by KeWaitForMultipleObjects()

Fix BSOD caused by KeWaitForMultipleObjects()

KeWaitForMultipleObjects() should use a wait block array if the
number of objects exceeds THREAD_WAIT_OBJECTS. The number of objects
PdoDestroy() waits on is 4 which exceeds the currently defined value
of that constant (which is 3).

Signed-off-by: Murtaza Ghiya <murtazg@amazon.com>
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge pull request #18 from OwenSmith/sctx-1718

Prevent certain GPO  settings triggering BSOD 0x7B on first reboot

Dont attempt to read values before setting to 0
Always attempt to set DisableCDDB and DontStartRawDevices to 0

Signed-off-by: Owen Smith <owen.smith@citrix.com>

[SCTX-1718] Set DisableCDDB and DontStartRawDevices to 0 before rebooting,
if GPO option to disallow device installations is enabled.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #16 from pauldu/gnttab

Fix a few build warnings

Fix a few build warnings

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge pull request #15 from pauldu/gnttab

Switch to new GNTTAB interface.

Switch to new GNTTAB interface.

This patch will break indirect but no shipping backend actually uses that
yet.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge pull request #14 from OwenSmith/indirect

Rename XENVBD_CONTEXT to XENVBD_MAPPING to better describe its use

Rename XENVBD_CONTEXT to XENVBD_MAPPING to better describe its use

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #13 from OwenSmith/indirect

Implement Indirect Operation

Tidy up some Verbose and DEBUG output

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Prepare, submit and cleanup BLKIF_OP_INDIRECT

When a read or write request would not fit into a single
BLKIF_OP_{READ/WRITE}, and the backend supports indirect
operations, prepare and submit a BLKIF_OP_INDIRECT and
handle the response.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Insert INDIRECT operations onto ring

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add missing Verbose parameter

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add XENVBD_REQUEST_INDIRECT

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Split PrepareReadWrite into seperate calls for Segments and Requests

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Split XENVBD_SEGMENT into segment data and bounce buffer context data

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Track Lookaside list max allocs and failed allocs better

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Read additional features/parameters (at appropriate state)

"feature-max-indirect-segments", "feature-persistent", "discard-secure"
"discard-alignment" and "discard-granularity"

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Track BLKIF_OP_{READ/WRITE} on per request basis, not per SRB

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Update blkif.h to include INDIRECT definitions

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #12 from OwenSmith/tags

Dont pass raw pointers to backend via req.id

Zero ring slot after processing response

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Pass a tag to blkif_request_t.id instead of a raw pointer.
Validate blkif_response_t.id is a correctly formatted tag before
retrieving the appropriate PXENVBD_REQUEST pointer.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #10 from OwenSmith/use-request-queue

Use request queue

Manage SrbStatus better.
Set to PENDING (once) before any actions occur, and only set to success when
completing the SRB. SrbStatus is set to a fail code if any Requests fail.
The fail code can be overwritten with a different fail code, but not with a
success code.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Wrap lookaside list access to an inline structure
Allows tight coupling of event, count and lookaside list access

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add handler for SCSIOP_UNMAP, translating to BLKIF_OP_DISCARD
Note: Storport will not generate SCSIOP_UNMAPs, a filter will be
      required to convert IOCTL_STORAGE_MANAGE_DATA_SET_ATTRIBUTES
  into SCSIOP_UNMAPs

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Refactor to improve code clarity

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Split XENVBD_REQUEST into unioned parts by BLKIF_OP_*

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Tidy up REQUEST preparation code,
Move scatter gather access to SGList* functions
Move mapping memory to seperate function
Reduce unneccessary local variable usage

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Reduce calls to BlockRingPush and NotifierSend during PdoSubmitPrepared
Remove ListContains assertions

Signed-off-by: Owen Smith <owen.smith@citrix.com>

No need to lock when accessing private front ring.
Move lock to insertion pathway only.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Tidy up code with Granter/Notifier/BlockRing accessors

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Remove unneeded include

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Enable single requests to be submitted to the ring

When a SRB has been prepared, its constituent requests are appended
to a request queue. Requests are submitted to the ring from this request
queue, allowing a SRB to be partially submitted due to limited free
slots on the ring.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #8 from OwenSmith/master

[SCTX-1663] Allow Closed -> Initialized state transition

[SCTX-1663] Make Closed->Initialized a valid transition.
Resuming from suspend, when the suspend occured before the
Initialized->Closed transition is valid, and the state needs to change
to allow subsiquent resumes to close the backend connection.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

[SCTX-1663] Prevent transitions to Initialized causing DEAD BSOD
on resume from suspend, when suspend occurs before transition out
of Initialized.

Also, fix minor typo in xencrsh/pdo.c

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add more logging to xencrsh

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge pull request #7 from OwenSmith/switch-xencrsh-to-grant-v1

Switch xencrsh to grant v1

Fix comments on prev commit
* #define MAXIMUM_GRANT_PAGES 1
* KeMemoryBarrier()

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Switch XENCRSH to grant v1

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Add back missing code to handle VDISK_REMOVABLE

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge pull request #4 from OwenSmith/upstream

Remove KeFlushQueuedDpcs on disable

Approved-By: Ben Chalmers <ben.chalmers@citrix.com>

Merge branch 'upstream' of github.com:OwenSmith/win-xenvbd into upstream

Remove KeFlushQueuedDpcs on disable

The DPC checks for state before doing anything, allowing
a DPC to run (and exit immidiately) should be safe.

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Merge branch 'upstream' of github.com:OwenSmith/win-xenvbd into upstream

Merge pull request #3 from benchalmers/upstream-ca-118809

[CA-118809] Use 64 bit abi
Approved By : owen.smith@citrix.com

[CA-118809] Use 64 bit abi

Signed-off-by: Ben Chalmers <Ben.Chalmers@citrix.com>

Fix typos

Signed-off-by: Owen Smith <owen.smith@citrix.com>

Fix typo

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

New README.md and INSTALL.md.

Also fix some python/cygwin issues and imported header line endings.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

ZwSetValueKey() was being called at DISPATCH_LEVEL from within the
enumeration code.

Change the code structure to only play with the registry from the outer
scan function which runs at PASSIVE_LEVEL.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Update build to reflect version

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Update to 7.2.0

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

MSVC apparently 8-byte aligns 8-byte objects even in 32-bit builds
so we need to use the 64-bit ABI to blkback/tap in all cases.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Add a DWORD value "NeedReboot" to the service key if a PDO fails
to start because either the EMULATED interface is not available, or
an alias has yet to be unplugged.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Advertize the correct ABI to the backend when connecting.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Merge branch 'upstream' of github.com:pauldu/win-xenvbd into upstream

Update to new GNTTAB interface

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>