]> xenbits.xensource.com Git - seabios.git/log
seabios.git
9 years agoPCI SDHCI driver: Fix base address
Kyösti Mälkki [Wed, 4 Nov 2015 05:40:12 +0000 (07:40 +0200)]
PCI SDHCI driver: Fix base address

MMIO register space was off by 4 bytes, bottom bits of
PCI BAR registers are not part of the address.

Test boot on real hardware:

PCI device 00:14.7 (vd=3D1022:7813 c=3D0805)

Searching bootorder for: /pci@i0cf8/*@14,7
sdhci@0xfeb25500 ver=3D1001 cap=3D31fe3fb2 2570
sdcard_set_frequency 63 400 8000
sdcard_pio command stop (code=3D1)
sdcard_set_frequency 63 25000 200
Found sdcard at 0xfeb25500: SD card SD01G 982MiB
Registering bootable: SD card SD01G 982MiB (type:2 prio:103 data:f46e0)

Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
9 years agodocs: Minor - replace seavgabios text in Build_overview.md with link
Kevin O'Connor [Mon, 26 Oct 2015 13:38:30 +0000 (09:38 -0400)]
docs: Minor - replace seavgabios text in Build_overview.md with link

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agovirtio: Minor - replace tab characters with space
Kevin O'Connor [Sun, 18 Oct 2015 15:27:50 +0000 (11:27 -0400)]
virtio: Minor - replace tab characters with space

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobiostables: Minor - fix incorrect indentation
Kevin O'Connor [Sun, 18 Oct 2015 15:25:15 +0000 (11:25 -0400)]
biostables: Minor - fix incorrect indentation

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agocoreboot: Minor - avoid K&R style function declaration
Kevin O'Connor [Sun, 18 Oct 2015 15:24:54 +0000 (11:24 -0400)]
coreboot: Minor - avoid K&R style function declaration

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: Allow official tarball builds to be considered "clean"
Kevin O'Connor [Thu, 22 Oct 2015 15:59:47 +0000 (11:59 -0400)]
build: Allow official tarball builds to be considered "clean"

If building from an official tarball and EXTRAVERSION info is
provided, then consider the build to be "clean" (don't include
hostname/build timestamp).  This is done on the expectation that
EXTRAVERSION will have enough information to allow developers to find
the builder and build environment should a defect be reported, and
therefore the hostname/timestamp is not necessary.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agodocs: Document 'make EXTRAVERSION=xyz' and scripts/tarball.sh
Kevin O'Connor [Thu, 22 Oct 2015 15:58:16 +0000 (11:58 -0400)]
docs: Document 'make EXTRAVERSION=xyz' and scripts/tarball.sh

Document the existence of the EXTRAVERSION field and the information
expected to be present in it.  Document the use of tarball.sh in build
environments that lack git.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: Be more permissive in buildversion.py tool version scan
Kevin O'Connor [Thu, 22 Oct 2015 00:35:50 +0000 (20:35 -0400)]
build: Be more permissive in buildversion.py tool version scan

There is some variation in version strings between various tool chain
builds.  Make the version tool scan more permissive to attempt to
handle these variations.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoAdd QEMU fw_cfg DMA interface
Marc Marí [Thu, 8 Oct 2015 15:03:26 +0000 (17:03 +0200)]
Add QEMU fw_cfg DMA interface

Add support for the new fw_cfg DMA interface. The protocol is explained in
QEMU documentation.

Signed-off-by: Marc Marí <markmb@redhat.com>
9 years agomalloc: Rename csm_malloc_preinit() to malloc_csm_preinit()
Kevin O'Connor [Thu, 15 Oct 2015 17:53:04 +0000 (13:53 -0400)]
malloc: Rename csm_malloc_preinit() to malloc_csm_preinit()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agostacks: Use macro wrappers for call32() and stack_hop_back()
Kevin O'Connor [Fri, 9 Oct 2015 15:53:02 +0000 (11:53 -0400)]
stacks: Use macro wrappers for call32() and stack_hop_back()

The C code only uses _cfuncX_ prefixes for parameters to the call32(),
stack_hop_back(), and call32_params() functions.  It's simpler to use
macro wrappers around those functions which provide the required
prefix.

This also changes the parameter order of stack_hop() and
stack_hop_back() to use the more natural (func, params) ordering.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: Generate "reproducible" version strings on "clean" builds
Kevin O'Connor [Tue, 13 Oct 2015 19:49:03 +0000 (15:49 -0400)]
build: Generate "reproducible" version strings on "clean" builds

If the build environment looks "clean" then don't add the build
hostname or build time to the version string.  This makes the default
build string reproducible across builds.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: Report gcc and binutils versions in debug log
Kevin O'Connor [Tue, 13 Oct 2015 19:44:25 +0000 (15:44 -0400)]
build: Report gcc and binutils versions in debug log

Attempt to extract the gcc and binutils versions.  Report that
information in the debug log.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: Rework version generation; don't allow make version override
Kevin O'Connor [Tue, 13 Oct 2015 19:09:40 +0000 (15:09 -0400)]
build: Rework version generation; don't allow make version override

Convert the script to generate the build version from a shell script
to a python script.

Remove the ability to override the version at build time via "make
VERSION=xyz".  Replace it with ability to add extra version
information at build time via "make EXTRAVERSION=xyz".

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomemmap: Introduce SYMBOL() macro to access linker script symbols
Kevin O'Connor [Thu, 8 Oct 2015 15:18:17 +0000 (11:18 -0400)]
memmap: Introduce SYMBOL() macro to access linker script symbols

Use a macro to define and obtain the value of a symbol introduced by
the linker scripts (scripts/layoutrom.py).

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomalloc: Don't mix virtual and physical addresses
Kevin O'Connor [Tue, 22 Sep 2015 18:45:25 +0000 (14:45 -0400)]
malloc: Don't mix virtual and physical addresses

Consistently use 'u32' for physical addresses and pointers for virtual
addresses in the malloc code.  Introduce and use memremap() where a
physical address needs to be converted to a virtual address.  Use
virt_to_phys() for the inverse.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomalloc: Add warning if free() called on invalid memory
Kevin O'Connor [Tue, 6 Oct 2015 19:37:53 +0000 (15:37 -0400)]
malloc: Add warning if free() called on invalid memory

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomalloc: Introduce common helper alloc_new_detail()
Kevin O'Connor [Tue, 29 Sep 2015 02:20:27 +0000 (22:20 -0400)]
malloc: Introduce common helper alloc_new_detail()

Introduce helper for finding temp space to hold an "allocation detail
struct" and use it in both alloc_add() and _malloc().

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomalloc: Use consistent naming for internal low-level "alloc" functions
Kevin O'Connor [Tue, 29 Sep 2015 01:45:38 +0000 (21:45 -0400)]
malloc: Use consistent naming for internal low-level "alloc" functions

Use the "alloc_" prefix for all the low-level allocation functions and
avoid camelCase naming.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agovirtio: Move standard definitions from virtio-ring.h to standard headers
Kevin O'Connor [Tue, 29 Sep 2015 14:14:58 +0000 (10:14 -0400)]
virtio: Move standard definitions from virtio-ring.h to standard headers

Move PAGE_SHIFT / virt_to_phys() to memmap.h and smp_[rw]mb() to
x86.h.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agovirtio: Simplify vring alignment code
Kevin O'Connor [Tue, 22 Sep 2015 15:46:48 +0000 (11:46 -0400)]
virtio: Simplify vring alignment code

Don't do phys_to_virt(virt_to_phys(vaddr)) for page alignment - page
alignment can be determined directly from the virtual address.

Use the ALIGN() macro to make the code more readable.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoe820: Update debugging messages to report 64bit values
Kevin O'Connor [Thu, 1 Oct 2015 03:00:43 +0000 (23:00 -0400)]
e820: Update debugging messages to report 64bit values

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoe820: Rename memmap.c to e820map.c and use consistent "e820_" prefix
Kevin O'Connor [Tue, 29 Sep 2015 13:40:46 +0000 (09:40 -0400)]
e820: Rename memmap.c to e820map.c and use consistent "e820_" prefix

Rename memmap.c to e820map.c as the code in that file only deals with
maintaining the e820 map.  Move all the e820 definitions to new file
e820map.h and use a consistent "e820_" prefix on all exported
functions.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoe820: Introduce e820_remove() and avoid exporting E820_HOLE
Kevin O'Connor [Tue, 29 Sep 2015 12:53:38 +0000 (08:53 -0400)]
e820: Introduce e820_remove() and avoid exporting E820_HOLE

The E820_HOLE definition is used internally in the e820 manipulation
code to remove entries from the e820 map.  Introduce the e820_remove()
function so that the E820_HOLE definition does not need to be exported
from the memmap.c code.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoFix typos found by codespell
Stefan Weil [Fri, 2 Oct 2015 06:46:40 +0000 (08:46 +0200)]
Fix typos found by codespell

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoAlways enable caching on transition32; backup/restore cr0 on call32
Kevin O'Connor [Tue, 22 Sep 2015 16:35:00 +0000 (12:35 -0400)]
Always enable caching on transition32; backup/restore cr0 on call32

Always enable caching at start of 32bit code and always make sure the
paging flag is off.  Because this alters the cr0 register, perform a
backup and restore of it when using call32().

Also, rename get/setcr0() to cr0_read/write() to more closely match
other register access functions.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoConsolidate code16*() functions
Kevin O'Connor [Tue, 22 Sep 2015 18:38:14 +0000 (14:38 -0400)]
Consolidate code16*() functions

Introduce code16_override() for cases where call16() should not
restore the previous 16bit state.  All callers now use call16_back()
to invoke 16bit code, so rename call16_back() to call16().

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoUse transition32_nmi_off from call32() and call16_back()
Kevin O'Connor [Fri, 11 Sep 2015 20:19:02 +0000 (16:19 -0400)]
Use transition32_nmi_off from call32() and call16_back()

The call32() and call16_back() functions will always disable NMI and
enable a20 (via the call32_prep() function) so it is safe to use the
_nmi_off variant of transition32.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoUnify call32_sloppy() and call32()
Kevin O'Connor [Fri, 11 Sep 2015 20:15:23 +0000 (16:15 -0400)]
Unify call32_sloppy() and call32()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoUnify inline assembler in variants of call16 functions
Kevin O'Connor [Fri, 11 Sep 2015 20:07:59 +0000 (16:07 -0400)]
Unify inline assembler in variants of call16 functions

The assembler between call16(), call16big() and call16_sloppy() are
very similar.  Rework the functions so that a single version of the
inline assembly can be used for all variants.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoRename Call32Data to Call16Data
Kevin O'Connor [Sun, 13 Sep 2015 14:03:12 +0000 (10:03 -0400)]
Rename Call32Data to Call16Data

The variable stores information on how and what to restore during a
call to 16bit code, so Call16Data is a better name.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoUnify smm/sloppy variants of call32_prep/post and call16_helper
Kevin O'Connor [Fri, 11 Sep 2015 19:38:43 +0000 (15:38 -0400)]
Unify smm/sloppy variants of call32_prep/post and call16_helper

The "smm" and "sloppy" variants of the 16bit to 32bit trampoline
backup/restore code are very similar.  They can be unified into a
single copy of each function.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agobuild: use -fstack-check=no when available
Magnus Granberg [Fri, 11 Sep 2015 21:38:40 +0000 (17:38 -0400)]
build: use -fstack-check=no when available

Some compilers (such as the one in hardened/Gentoo) default this
option to on which leads to build failures:
src/stacks.c: In function 'call16_back':
src/stacks.c:139:5: error: 'asm' operand has impossible constraints
     asm volatile(
     ^

URL: https://bugs.gentoo.org/559980
Reported-by: Alon Bar-Lev <alonbl@gentoo.org>
Signed-off-by: Magnus Granberg <zorry@gentoo.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
9 years agodocs: Minor - add "code relocation" link to "Execution and code flow" document
Kevin O'Connor [Tue, 8 Sep 2015 18:28:19 +0000 (14:28 -0400)]
docs: Minor - add "code relocation" link to "Execution and code flow" document

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoSimplify transition16/32 assembler code
Kevin O'Connor [Thu, 3 Sep 2015 16:23:53 +0000 (12:23 -0400)]
Simplify transition16/32 assembler code

Backup and restore %eax only around code that needs to use %eax.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agominor - correct spelling error in comment
Kevin O'Connor [Thu, 3 Sep 2015 16:21:51 +0000 (12:21 -0400)]
minor - correct spelling error in comment

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomegasas: Use outl() on MFI_IDB register
Kevin O'Connor [Thu, 3 Sep 2015 14:00:57 +0000 (10:00 -0400)]
megasas: Use outl() on MFI_IDB register

The outw() should be an outl().

Reported-by: Stefan Weil <sw@weilnetz.de>
Reported-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomegasas: Fix outw, outl argument order
Stefan Weil [Sat, 29 Aug 2015 06:02:38 +0000 (08:02 +0200)]
megasas: Fix outw, outl argument order

The value is the first argument and the port is the second,
but the code was using the opposite order.

Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
9 years agosdcard: Obtain card capacity and report it on the boot menu
Kevin O'Connor [Mon, 24 Aug 2015 17:48:54 +0000 (13:48 -0400)]
sdcard: Obtain card capacity and report it on the boot menu

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Display sdcard product name in boot menu
Kevin O'Connor [Tue, 18 Aug 2015 16:43:04 +0000 (12:43 -0400)]
sdcard: Display sdcard product name in boot menu

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Turn card_type into a bitmap and store if card is MMC type
Kevin O'Connor [Mon, 24 Aug 2015 16:36:56 +0000 (12:36 -0400)]
sdcard: Turn card_type into a bitmap and store if card is MMC type

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Move drive registration to sdcard_card_setup()
Kevin O'Connor [Tue, 18 Aug 2015 15:44:46 +0000 (11:44 -0400)]
sdcard: Move drive registration to sdcard_card_setup()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Move frequency setting into sdcard_card_setup()
Kevin O'Connor [Tue, 18 Aug 2015 15:33:41 +0000 (11:33 -0400)]
sdcard: Move frequency setting into sdcard_card_setup()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c
Kevin O'Connor [Tue, 18 Aug 2015 15:22:25 +0000 (11:22 -0400)]
sdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c

Just code movement; no code changes.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agortc: Disable NMI in rtc_mask()
Kevin O'Connor [Tue, 1 Sep 2015 23:43:08 +0000 (19:43 -0400)]
rtc: Disable NMI in rtc_mask()

The rtc_mask() function should make sure the NMI disable bit is set
(just as rtc_read() and rtc_write() do).

Reported-by: Tim Shearer <tim.shearer@overturenetworks.com>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agodocs: Don't use an add-symbol-file offset when describing gdb debugging
Kevin O'Connor [Mon, 24 Aug 2015 19:12:10 +0000 (15:12 -0400)]
docs: Don't use an add-symbol-file offset when describing gdb debugging

Recent versions of gdb will only add an offset to the '.text' section
of object files via the add-symbol-file command.  The SeaBIOS build
doesn't place code directly in a '.text' section, so update the
documentation to obtain the same result via an 'objcopy' call instead.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoxhci: Minor - add USB port type comments to xhci_hub_reset()
Kevin O'Connor [Mon, 24 Aug 2015 13:50:30 +0000 (09:50 -0400)]
xhci: Minor - add USB port type comments to xhci_hub_reset()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Allow sdcard addresses to be specified in CBFS files
Kevin O'Connor [Mon, 10 Aug 2015 16:51:41 +0000 (12:51 -0400)]
sdcard: Allow sdcard addresses to be specified in CBFS files

Allow a hardcoded address to be specified in cbfs files with a prefix
of "etc/sdcard".  Some real-world devices have valid SDHCI controllers
that do not show up as PCI devices.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agops2: Eliminate "etc/ps2-poll-only"; use CONFIG_HARDWARE_IRQ instead
Kevin O'Connor [Mon, 10 Aug 2015 19:50:53 +0000 (15:50 -0400)]
ps2: Eliminate "etc/ps2-poll-only"; use CONFIG_HARDWARE_IRQ instead

The "etc/ps2-poll-only" runtime setting is directly tied to the new
CONFIG_HARDWARE_IRQ setting - use the compile time setting to control
both.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoAdd minimal support for machines without hardware interrupts
Kevin O'Connor [Mon, 10 Aug 2015 20:14:48 +0000 (16:14 -0400)]
Add minimal support for machines without hardware interrupts

Some Chromebooks (with Baytrail CPUs) apparently do not support
routing of legacy interrupts.  This patch adds minimal support for
running SeaBIOS in such an environment.  Even with this patch, it is
known that old operating systems and even some recent bootloaders will
not function without real hardware interrupts.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agortc: Support disabling the RTC timer irq support
Kevin O'Connor [Thu, 13 Aug 2015 15:43:27 +0000 (11:43 -0400)]
rtc: Support disabling the RTC timer irq support

Add a build time config option to remove support for RTC timer
interrupts along with the associated bios calls requiring that
support.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Allow the sdcard driver to run on real hardware
Kevin O'Connor [Mon, 10 Aug 2015 19:41:03 +0000 (15:41 -0400)]
sdcard: Allow the sdcard driver to run on real hardware

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Initial support for MMC cards
Kevin O'Connor [Tue, 11 Aug 2015 17:29:55 +0000 (13:29 -0400)]
sdcard: Initial support for MMC cards

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Check for error events during sdcard_pio()
Kevin O'Connor [Wed, 12 Aug 2015 16:07:17 +0000 (12:07 -0400)]
sdcard: Check for error events during sdcard_pio()

Check for command errors and clear the error status if an error is
found.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Perform a controller reset at start of init
Kevin O'Connor [Wed, 12 Aug 2015 16:02:16 +0000 (12:02 -0400)]
sdcard: Perform a controller reset at start of init

Ask the controller to reset itself during controller setup.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Rename waitw() to sdcard_waitw() and simplify
Kevin O'Connor [Tue, 11 Aug 2015 17:03:22 +0000 (13:03 -0400)]
sdcard: Rename waitw() to sdcard_waitw() and simplify

Calculate end timeout in code and return if any bit in the provided
mask is set.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Implement timeout on every block read in sdcard_pio_transfer()
Kevin O'Connor [Wed, 12 Aug 2015 16:58:23 +0000 (12:58 -0400)]
sdcard: Implement timeout on every block read in sdcard_pio_transfer()

The sdcard specs don't specify a maximum time for arbitrary transfers.
Instead, each block has a maximum timeout.  So, change the code to
check for a timeout on each block transferred.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: The card should never be in a busy state at start of sdcard_pio()
Kevin O'Connor [Tue, 11 Aug 2015 16:59:53 +0000 (12:59 -0400)]
sdcard: The card should never be in a busy state at start of sdcard_pio()

Return an error if the controller is busy at the start of a command
instead of waiting.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Power down controller on failure
Kevin O'Connor [Tue, 11 Aug 2015 15:59:34 +0000 (11:59 -0400)]
sdcard: Power down controller on failure

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Power controller up to maximum voltage supported
Kevin O'Connor [Tue, 11 Aug 2015 15:56:51 +0000 (11:56 -0400)]
sdcard: Power controller up to maximum voltage supported

Don't error out if the controller does not support 3.3V - instead
supply the most voltage the controller supports.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Move power setup to new function sdcard_set_power()
Kevin O'Connor [Tue, 11 Aug 2015 15:47:57 +0000 (11:47 -0400)]
sdcard: Move power setup to new function sdcard_set_power()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Support SDHCI v3.00 spec clock setting
Kevin O'Connor [Tue, 11 Aug 2015 13:34:19 +0000 (09:34 -0400)]
sdcard: Support SDHCI v3.00 spec clock setting

The SDHCI v3 spec supports higher frequency clocks and has a different
method to configure the clock divisor.

This also fixes an error in v1/v2 clock calculation (ffs was used
instead of fls).

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Fill command bits according to spec
Kevin O'Connor [Tue, 11 Aug 2015 03:40:50 +0000 (23:40 -0400)]
sdcard: Fill command bits according to spec

Set the proper command bits for each command according to the SDHCI
specification.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Fix typo - use sdcard_pio() instead of sdcard_pio_app()
Kevin O'Connor [Mon, 10 Aug 2015 23:11:15 +0000 (19:11 -0400)]
sdcard: Fix typo - use sdcard_pio() instead of sdcard_pio_app()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoCall cpu_relax() if yielding prior to interrupts being enabled
Kevin O'Connor [Fri, 7 Aug 2015 20:13:18 +0000 (16:13 -0400)]
Call cpu_relax() if yielding prior to interrupts being enabled

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoMove CanInterrupt check to check_irqs()
Kevin O'Connor [Fri, 7 Aug 2015 20:12:02 +0000 (16:12 -0400)]
Move CanInterrupt check to check_irqs()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoedd: Reduce parameters to fill_generic_edd()
Kevin O'Connor [Wed, 5 Aug 2015 19:02:01 +0000 (15:02 -0400)]
edd: Reduce parameters to fill_generic_edd()

Have callers of fill_generic_edd() calculate the edd iface_path
field.  Have callers determine if the bus type is PCI vs ISA.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoedd: Pass the segment/offset from int 1348 calls using a 'struct segoff_s'
Kevin O'Connor [Mon, 27 Jul 2015 14:41:41 +0000 (10:41 -0400)]
edd: Pass the segment/offset from int 1348 calls using a 'struct segoff_s'

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agooptionroms: Don't run option rom on PCI bar if CBFS/fw_cfg version exists
Kevin O'Connor [Mon, 10 Aug 2015 19:37:13 +0000 (15:37 -0400)]
optionroms: Don't run option rom on PCI bar if CBFS/fw_cfg version exists

If there exists a "pci%04x,%04x.rom" file in CBFS/fw_cfg then the code
should not attempt to run a rom found on the PCI device itself - even
if the one in CBFS/fw_cfg is not a valid rom.  This makes the code
match the documentation.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoxhci: Count new Max Scratchpad Bufs bits from XHCI 1.1
Julius Werner [Sat, 8 Aug 2015 03:07:12 +0000 (20:07 -0700)]
xhci: Count new Max Scratchpad Bufs bits from XHCI 1.1

The 1.1 revision of the XHCI specification added an extra 5 bits to the
Max Scratchpad Bufs field of HCSPARAMS2 that newer controllers make use
of. Not honoring these bits means we're not allocating as many
scratchpad buffers as the controller expects, which means it will
interpret some uninitialized values from the end of the pointer array as
scratchpad buffer pointers.

We just fixed this in libpayload and it seems to apply the same way to
SeaBIOS (I only compile-tested this, though... sorry).

Signed-off-by: Julius Werner <jwerner@chromium.org>
9 years agomptable: Don't create mptable if it is very large
Kevin O'Connor [Mon, 3 Aug 2015 14:16:39 +0000 (10:16 -0400)]
mptable: Don't create mptable if it is very large

Very large mptable structures can fill up the space in the f-segment
and cause other important f-segment allocations to fail.  Limit the
maximum size of the mptable to prevent this.

On QEMU, with the current maximum size of 600 bytes, the mptable will
not be created in configurations of ~20 cpus or more.  The mptable is
rarely used in modern OSes so this should not be a problem.

Reported-by: Huaitong Han <huaitong.han@intel.com>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Add proper delays during card power up
Kevin O'Connor [Tue, 4 Aug 2015 14:01:02 +0000 (10:01 -0400)]
sdcard: Add proper delays during card power up

Add card power up timing delays as specified by the sd card "Physical
Layer Simplified Specification Version 4.10".

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Improve SD card initialization command sequence
Kevin O'Connor [Thu, 30 Jul 2015 14:56:00 +0000 (10:56 -0400)]
sdcard: Improve SD card initialization command sequence

Send the initialization commands that are specified for SD cards by
the "SD Host Controller Simplified Specification Version 2.00" spec.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Set timeout control register during init (to max allowed timeout)
Kevin O'Connor [Tue, 28 Jul 2015 18:15:37 +0000 (14:15 -0400)]
sdcard: Set timeout control register during init (to max allowed timeout)

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Make sure controller support 3.3V before enabling it
Kevin O'Connor [Tue, 4 Aug 2015 13:48:30 +0000 (09:48 -0400)]
sdcard: Make sure controller support 3.3V before enabling it

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Implement controller frequency setting according to sdhci spec
Kevin O'Connor [Tue, 28 Jul 2015 17:40:04 +0000 (13:40 -0400)]
sdcard: Implement controller frequency setting according to sdhci spec

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosdcard: Check if card is present before sending commands to card
Kevin O'Connor [Tue, 28 Jul 2015 17:06:41 +0000 (13:06 -0400)]
sdcard: Check if card is present before sending commands to card

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agovgafb: Minor - move gfx_common() variables outside of switch statement
Kevin O'Connor [Thu, 30 Jul 2015 16:42:47 +0000 (12:42 -0400)]
vgafb: Minor - move gfx_common() variables outside of switch statement

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosmm: ignore bits 16,18-31 of SMM revision ID at runtime too
Kevin O'Connor [Thu, 30 Jul 2015 16:39:12 +0000 (12:39 -0400)]
smm: ignore bits 16,18-31 of SMM revision ID at runtime too

Check only the relevant bits of the SMM revision ID for both the init
check and during runtime checks.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agosmm: fix outl argument order
Paolo Bonzini [Mon, 27 Jul 2015 10:23:58 +0000 (12:23 +0200)]
smm: fix outl argument order

The value is the first argument and the port is the second, but the code
was using the opposite order.

Reported-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
9 years agoMinor - move declaration of CDRom_locks to code that uses it
Kevin O'Connor [Fri, 24 Jul 2015 17:17:38 +0000 (13:17 -0400)]
Minor - move declaration of CDRom_locks to code that uses it

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoramdisk: Allow ramdisk support (CONFIG_FLASH_FLOPPY) under QEMU
Kevin O'Connor [Thu, 23 Jul 2015 13:19:23 +0000 (09:19 -0400)]
ramdisk: Allow ramdisk support (CONFIG_FLASH_FLOPPY) under QEMU

Don't require coreboot to use CONFIG_FLASH_FLOPPY - with the latest
QEMU, it's possible to place a floppy image into fw_cfg using the qemu
command line (eg, "-fw_cfg name=floppyimg/MyFloppy,file=file.img").

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agotimer: Add CONFIG_TSC_TIMER build option to disable the CPU TSC timer
Kevin O'Connor [Thu, 23 Jul 2015 12:36:01 +0000 (08:36 -0400)]
timer: Add CONFIG_TSC_TIMER build option to disable the CPU TSC timer

Allow users to remove the CPU timestamp counter support at compile
time.  The PMTIMER is frequently used instead of the TSC and this
compile time option allows one to strip a few bytes from the final
binary.  This change also defaults the internal timer to use the PIT
based timer until the PMTIMER or TSC is detected.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agotimer: Delay timestamp counter init until after pmtimer is probed
Kevin O'Connor [Wed, 22 Jul 2015 20:06:27 +0000 (16:06 -0400)]
timer: Delay timestamp counter init until after pmtimer is probed

Delay call to timer_setup() until after the xxx_platform_setup() calls
so that the pmtimer can be detected first.  Most modern machines will
have a pmtimer and calibrating the timestamp counter is frequently
unnecessary.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agops2: Don't wait 100ms to discard possible extra reset receive byte
Kevin O'Connor [Wed, 22 Jul 2015 18:32:28 +0000 (14:32 -0400)]
ps2: Don't wait 100ms to discard possible extra reset receive byte

The existing PS2 port code waits 100ms to see if the device attached
to the keyboard port responds to a reset command with two bytes
(instead of the normal one byte).  If an extra byte is received, it is
discarded.

Receiving two bytes would be unusual and waiting to check for that
event is unnecessary because the next command in the keyboard init
sequence already seamlessly discards any extra bytes in the command
queue.

This patch eliminates the 100ms wait, which notably reduces the
SeaBIOS boot time on QEMU.  This patch also forces PS2 mice to always
respond with two bytes during a reset sequence (instead of just one
byte), which is a good sanity check.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoDon't enable interrupts prior to IVT and PIC setup
Kevin O'Connor [Tue, 14 Jul 2015 19:44:26 +0000 (15:44 -0400)]
Don't enable interrupts prior to IVT and PIC setup

The machine may crash if an interrupt occurs prior to the setup of the
interrupt vector table (IVT) and programmable interrupt controller
(PIC).  This patch makes sure that interrupts remain disabled until
these components are setup.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoata: Make sure "chanid" is relative to PCI device for bootorder file
Kevin O'Connor [Tue, 14 Jul 2015 19:12:25 +0000 (15:12 -0400)]
ata: Make sure "chanid" is relative to PCI device for bootorder file

When specifying drives in the bootorder file, the "drive@x" parameter
should be relative to the given PCI device and not relative to the
total number of ATA controllers in the machine.  This patch separates
the tracking of "chanid" (channel number relative to a given PCI
devices) from the "ataid" (channel number relative to the total number
of ATA channels).

Reported-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agops2: Support mode for polling the PS2 port instead of using irqs
Kevin O'Connor [Wed, 12 Nov 2014 17:15:34 +0000 (12:15 -0500)]
ps2: Support mode for polling the PS2 port instead of using irqs

Some recent hardware has trouble with routing PS2 port interrupts
while the interrupt controller is in legacy routing mode.  This patch
adds a config mechanism (via "etc/ps2-poll-only") to force the PS2
code into a polling only mode so that interrupts are not required.

It is not recommended to use this polling mode on hardware that does
properly support PS2 irqs, because some very old (DOS-era) programs
depend on the BIOS PS2 irq behavior.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agocoreboot: Try to auto-detect if the CBFS anchor pointer is a relative pointer
Kevin O'Connor [Wed, 8 Jul 2015 23:05:54 +0000 (19:05 -0400)]
coreboot: Try to auto-detect if the CBFS anchor pointer is a relative pointer

If CONFIG_CBFS_LOCATION is set to a non-zero value then it means the
CBFS flash is not at the very end of memory.  In this case, it's
unclear if the anchor pointer is an absolute pointer or if it is
relative to CONFIG_CBFS_LOCATION.  Some devices have been using
absolute pointers, but it appears some devices are now using relative
pointers there.  Since the anchor pointer almost always points to a
structure in the last 64K of the rom, it should be possible to
auto-detect if the pointer is relative or not.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoblock: Rename process_XXX_op() functions to XXX_process_op()
Kevin O'Connor [Tue, 7 Jul 2015 18:56:20 +0000 (14:56 -0400)]
block: Rename process_XXX_op() functions to XXX_process_op()

Rename disk driver dispatch functions to a consistent naming style.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoblockcmd: Convert cdb_is_read() to scsi_is_read()
Kevin O'Connor [Tue, 7 Jul 2015 18:43:01 +0000 (14:43 -0400)]
blockcmd: Convert cdb_is_read() to scsi_is_read()

Convert the cdb_is_read() function to a new function scsi_is_read()
which takes a 'struct disk_op_s' as a paramter.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoblockcmd: Remove unused scsi_process_op() and cdb_cmd_data()
Kevin O'Connor [Tue, 7 Jul 2015 16:46:20 +0000 (12:46 -0400)]
blockcmd: Remove unused scsi_process_op() and cdb_cmd_data()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agopvscsi: Handle pvscsi drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 16:35:34 +0000 (12:35 -0400)]
pvscsi: Handle pvscsi drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agopvscsi: Move pvscsi_fill_req() code into pvscsi_cmd()
Kevin O'Connor [Tue, 7 Jul 2015 16:24:50 +0000 (12:24 -0400)]
pvscsi: Move pvscsi_fill_req() code into pvscsi_cmd()

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agovirtio-scsi: Handle virtio drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 16:19:53 +0000 (12:19 -0400)]
virtio-scsi: Handle virtio drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agomegasas: Handle Megasas drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 16:06:01 +0000 (12:06 -0400)]
megasas: Handle Megasas drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agoesp-scsi: Handle ESP drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 15:57:50 +0000 (11:57 -0400)]
esp-scsi: Handle ESP drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agolsi-scsi: Handle LSI drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 15:51:08 +0000 (11:51 -0400)]
lsi-scsi: Handle LSI drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agousb-uas: Handle USB drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 15:43:34 +0000 (11:43 -0400)]
usb-uas: Handle USB drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
9 years agousb-msc: Handle USB drives directly via 'struct disk_op_s' requests
Kevin O'Connor [Tue, 7 Jul 2015 15:35:25 +0000 (11:35 -0400)]
usb-msc: Handle USB drives directly via 'struct disk_op_s' requests

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>