Jonathan Corbet [Mon, 4 Oct 2010 23:06:33 +0000 (17:06 -0600)]
Make tag matching stricter
If you commit a git changelog to your repository, gitdm will be confused by
all the added patch tags. So make the patterns stricter to force them only
to match within the git log metadata - or so we hope. There is still room
for confusion here; we really need to make grabpatch() smart enough to
split metadata and the diff. Don't have time for that now.
This patch changes results slightly. In the 2.6.36 cycle, there's a tag
reading:
Original-Idea-and-Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Pre-patch gitdm would recognize that as a signoff; after the change it no
longer does.
Reported-by: Wolfgang Denk <wd@denx.de> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Tiago Vignatti [Wed, 30 Jun 2010 17:13:21 +0000 (20:13 +0300)]
Add option to get the configuration files from a given base directory
Instead boringly be replicating the directory base name where gitdm is
installed and write it on each option inside the configuration file, just send
it through the command line.
Martin Nordholts [Sun, 20 Dec 2009 08:41:07 +0000 (09:41 +0100)]
Move out global houskeeping from grabpatch()
As a step to make grabpatch() more unit-test friendly, move out global
houskeeping from grabpatch(). This also gets rid of a TODO in the
code. The regression tests still passes after this refactoring, of
course.
Signed-off-by: Martin Nordholts <martinn@src.gnome.org>
Martin Nordholts [Sat, 19 Dec 2009 14:59:34 +0000 (15:59 +0100)]
Add regression tests on gitdm output files
Add simple regression tests that makes sure there are no regressions
in the text output file and the date line count file. The primary
purpose of introducing this regression test is to allow us to safely
refactor the gitdm code.
Signed-off-by: Martin Nordholts <martinn@src.gnome.org>
gitdm: report issue when an email address is a "name"
This probably means an incorrect commit message, it also
means that if it is not fixed, the category for this person is probably
going to be incorrect.
Jonathan Corbet [Thu, 13 Nov 2008 16:13:25 +0000 (09:13 -0700)]
Better email address handling
Some people quote their names in various tags:
Something-done-by: "J Random Hacker" <...>
We kept the quotes with the name, confusing things down the road. So
change the patterns to exclude those quotes when they exist.
with chart here:
http://www.gnome.org/~michael/images/2008-09-29-kernel-active.png
caption being:
"Graph showing number and affiliation of active kernel developers
(contributing more than 100 lines per month). Quick affiliation key,
from bottom up: Unknown, No-Affiliation, IBM, RedHat, Novell, Intel ..."
These are as yet not published, I plan to use them as a comparison to
OO.o's somewhat mediocre equivalents; hope to go live with them soon
(and fix the horrible bugs in stacked area charts to make them actually
pretty ).
Jonathan Corbet [Fri, 5 Sep 2008 19:53:35 +0000 (13:53 -0600)]
Don't accept totally bogus dates
Yanmin Zhang committed a patch (09f2724a786f76475ef2985cf84f5359c553aade)
which claims to have been written in August, 2030. Code that bleeding-edge
makes gitdm confused, so pretend it's just normal, contemporary stuff.
Kir Kolyshkin [Mon, 7 Apr 2008 19:59:18 +0000 (23:59 +0400)]
gitdm: Report progress to stderr not stdout
When gitdm is used for generating text-only report with its output
redirected to a file, all is well aside from the clutter at the beginning
of that file -- a very long line with repeating "Grabbing changesets...".
Solve that by redirecting progress reporting to stderr. It also helps to
see the progress when you redirect gitdm output to a file.
Also, we don't have to flush stdout since stderr is unbuffered by default.
Signed-off-by: Kir Kolyshkin <kir@openvz.org> Signed-off-by: Jonathan Corbet <corbet@lwn.net>